| Index: mojo/edk/system/multiprocess_message_pipe_unittest.cc
|
| diff --git a/mojo/edk/system/multiprocess_message_pipe_unittest.cc b/mojo/edk/system/multiprocess_message_pipe_unittest.cc
|
| index 08de47754dc9fb22a42dc5b7e10581efa0741c31..7f33e96d07c1277ac7aaa292f10b63b6d3d328e6 100644
|
| --- a/mojo/edk/system/multiprocess_message_pipe_unittest.cc
|
| +++ b/mojo/edk/system/multiprocess_message_pipe_unittest.cc
|
| @@ -49,7 +49,7 @@ MOJO_MULTIPROCESS_TEST_CHILD_MAIN(EchoEcho) {
|
| mojo::test::MultiprocessTestHelper::client_platform_handle.Pass();
|
| CHECK(client_platform_handle.is_valid());
|
| RefPtr<ChannelEndpoint> ep;
|
| - scoped_refptr<MessagePipe> mp(MessagePipe::CreateLocalProxy(&ep));
|
| + auto mp = MessagePipe::CreateLocalProxy(&ep);
|
| channel_thread.Start(client_platform_handle.Pass(), std::move(ep));
|
|
|
| const std::string quitquitquit("quitquitquit");
|
| @@ -58,7 +58,7 @@ MOJO_MULTIPROCESS_TEST_CHILD_MAIN(EchoEcho) {
|
| // Wait for our end of the message pipe to be readable.
|
| HandleSignalsState hss;
|
| MojoResult result =
|
| - test::WaitIfNecessary(mp, MOJO_HANDLE_SIGNAL_READABLE, &hss);
|
| + test::WaitIfNecessary(mp.get(), MOJO_HANDLE_SIGNAL_READABLE, &hss);
|
| if (result != MOJO_RESULT_OK) {
|
| // It was closed, probably.
|
| CHECK_EQ(result, MOJO_RESULT_FAILED_PRECONDITION);
|
| @@ -106,7 +106,7 @@ TEST_F(MultiprocessMessagePipeTest, MAYBE_Basic) {
|
| helper()->StartChild("EchoEcho");
|
|
|
| RefPtr<ChannelEndpoint> ep;
|
| - scoped_refptr<MessagePipe> mp(MessagePipe::CreateLocalProxy(&ep));
|
| + auto mp = MessagePipe::CreateLocalProxy(&ep);
|
| Init(std::move(ep));
|
|
|
| std::string hello("hello");
|
| @@ -117,7 +117,7 @@ TEST_F(MultiprocessMessagePipeTest, MAYBE_Basic) {
|
|
|
| HandleSignalsState hss;
|
| EXPECT_EQ(MOJO_RESULT_OK,
|
| - test::WaitIfNecessary(mp, MOJO_HANDLE_SIGNAL_READABLE, &hss));
|
| + test::WaitIfNecessary(mp.get(), MOJO_HANDLE_SIGNAL_READABLE, &hss));
|
| // The child may or may not have closed its end of the message pipe and died
|
| // (and we may or may not know it yet), so our end may or may not appear as
|
| // writable.
|
| @@ -152,7 +152,7 @@ TEST_F(MultiprocessMessagePipeTest, DISABLED_QueueMessages) {
|
| helper()->StartChild("EchoEcho");
|
|
|
| RefPtr<ChannelEndpoint> ep;
|
| - scoped_refptr<MessagePipe> mp(MessagePipe::CreateLocalProxy(&ep));
|
| + auto mp = MessagePipe::CreateLocalProxy(&ep);
|
| Init(std::move(ep));
|
|
|
| static const size_t kNumMessages = 1001;
|
| @@ -172,8 +172,8 @@ TEST_F(MultiprocessMessagePipeTest, DISABLED_QueueMessages) {
|
|
|
| for (size_t i = 0; i < kNumMessages; i++) {
|
| HandleSignalsState hss;
|
| - EXPECT_EQ(MOJO_RESULT_OK,
|
| - test::WaitIfNecessary(mp, MOJO_HANDLE_SIGNAL_READABLE, &hss));
|
| + EXPECT_EQ(MOJO_RESULT_OK, test::WaitIfNecessary(
|
| + mp.get(), MOJO_HANDLE_SIGNAL_READABLE, &hss));
|
| // The child may or may not have closed its end of the message pipe and died
|
| // (and we may or may not know it yet), so our end may or may not appear as
|
| // writable.
|
| @@ -195,7 +195,7 @@ TEST_F(MultiprocessMessagePipeTest, DISABLED_QueueMessages) {
|
| // "quitquitquit").
|
| HandleSignalsState hss;
|
| EXPECT_EQ(MOJO_RESULT_FAILED_PRECONDITION,
|
| - test::WaitIfNecessary(mp, MOJO_HANDLE_SIGNAL_READABLE, &hss));
|
| + test::WaitIfNecessary(mp.get(), MOJO_HANDLE_SIGNAL_READABLE, &hss));
|
| EXPECT_EQ(MOJO_HANDLE_SIGNAL_PEER_CLOSED, hss.satisfied_signals);
|
| EXPECT_EQ(MOJO_HANDLE_SIGNAL_PEER_CLOSED, hss.satisfiable_signals);
|
|
|
| @@ -212,12 +212,12 @@ MOJO_MULTIPROCESS_TEST_CHILD_MAIN(CheckSharedBuffer) {
|
| mojo::test::MultiprocessTestHelper::client_platform_handle.Pass();
|
| CHECK(client_platform_handle.is_valid());
|
| RefPtr<ChannelEndpoint> ep;
|
| - scoped_refptr<MessagePipe> mp(MessagePipe::CreateLocalProxy(&ep));
|
| + auto mp = MessagePipe::CreateLocalProxy(&ep);
|
| channel_thread.Start(client_platform_handle.Pass(), std::move(ep));
|
|
|
| // Wait for the first message from our parent.
|
| HandleSignalsState hss;
|
| - CHECK_EQ(test::WaitIfNecessary(mp, MOJO_HANDLE_SIGNAL_READABLE, &hss),
|
| + CHECK_EQ(test::WaitIfNecessary(mp.get(), MOJO_HANDLE_SIGNAL_READABLE, &hss),
|
| MOJO_RESULT_OK);
|
| // In this test, the parent definitely doesn't close its end of the message
|
| // pipe before we do.
|
| @@ -269,7 +269,7 @@ MOJO_MULTIPROCESS_TEST_CHILD_MAIN(CheckSharedBuffer) {
|
|
|
| // Now wait for our parent to send us a message.
|
| hss = HandleSignalsState();
|
| - CHECK_EQ(test::WaitIfNecessary(mp, MOJO_HANDLE_SIGNAL_READABLE, &hss),
|
| + CHECK_EQ(test::WaitIfNecessary(mp.get(), MOJO_HANDLE_SIGNAL_READABLE, &hss),
|
| MOJO_RESULT_OK);
|
| CHECK_EQ(hss.satisfied_signals,
|
| MOJO_HANDLE_SIGNAL_READABLE | MOJO_HANDLE_SIGNAL_WRITABLE);
|
| @@ -306,7 +306,7 @@ TEST_F(MultiprocessMessagePipeTest, MAYBE_SharedBufferPassing) {
|
| helper()->StartChild("CheckSharedBuffer");
|
|
|
| RefPtr<ChannelEndpoint> ep;
|
| - scoped_refptr<MessagePipe> mp(MessagePipe::CreateLocalProxy(&ep));
|
| + auto mp = MessagePipe::CreateLocalProxy(&ep);
|
| Init(std::move(ep));
|
|
|
| // Make a shared buffer.
|
| @@ -345,7 +345,7 @@ TEST_F(MultiprocessMessagePipeTest, MAYBE_SharedBufferPassing) {
|
| // Wait for a message from the child.
|
| HandleSignalsState hss;
|
| EXPECT_EQ(MOJO_RESULT_OK,
|
| - test::WaitIfNecessary(mp, MOJO_HANDLE_SIGNAL_READABLE, &hss));
|
| + test::WaitIfNecessary(mp.get(), MOJO_HANDLE_SIGNAL_READABLE, &hss));
|
| EXPECT_TRUE((hss.satisfied_signals & MOJO_HANDLE_SIGNAL_READABLE));
|
| EXPECT_TRUE((hss.satisfiable_signals & MOJO_HANDLE_SIGNAL_READABLE));
|
|
|
| @@ -377,7 +377,7 @@ TEST_F(MultiprocessMessagePipeTest, MAYBE_SharedBufferPassing) {
|
| // Wait for |mp| to become readable, which should fail.
|
| hss = HandleSignalsState();
|
| EXPECT_EQ(MOJO_RESULT_FAILED_PRECONDITION,
|
| - test::WaitIfNecessary(mp, MOJO_HANDLE_SIGNAL_READABLE, &hss));
|
| + test::WaitIfNecessary(mp.get(), MOJO_HANDLE_SIGNAL_READABLE, &hss));
|
| EXPECT_EQ(MOJO_HANDLE_SIGNAL_PEER_CLOSED, hss.satisfied_signals);
|
| EXPECT_EQ(MOJO_HANDLE_SIGNAL_PEER_CLOSED, hss.satisfiable_signals);
|
|
|
| @@ -393,11 +393,11 @@ MOJO_MULTIPROCESS_TEST_CHILD_MAIN(CheckPlatformHandleFile) {
|
| mojo::test::MultiprocessTestHelper::client_platform_handle.Pass();
|
| CHECK(client_platform_handle.is_valid());
|
| RefPtr<ChannelEndpoint> ep;
|
| - scoped_refptr<MessagePipe> mp(MessagePipe::CreateLocalProxy(&ep));
|
| + auto mp = MessagePipe::CreateLocalProxy(&ep);
|
| channel_thread.Start(client_platform_handle.Pass(), std::move(ep));
|
|
|
| HandleSignalsState hss;
|
| - CHECK_EQ(test::WaitIfNecessary(mp, MOJO_HANDLE_SIGNAL_READABLE, &hss),
|
| + CHECK_EQ(test::WaitIfNecessary(mp.get(), MOJO_HANDLE_SIGNAL_READABLE, &hss),
|
| MOJO_RESULT_OK);
|
| CHECK_EQ(hss.satisfied_signals,
|
| MOJO_HANDLE_SIGNAL_READABLE | MOJO_HANDLE_SIGNAL_WRITABLE);
|
| @@ -453,7 +453,7 @@ TEST_P(MultiprocessMessagePipeTestWithPipeCount, PlatformHandlePassing) {
|
| helper()->StartChild("CheckPlatformHandleFile");
|
|
|
| RefPtr<ChannelEndpoint> ep;
|
| - scoped_refptr<MessagePipe> mp(MessagePipe::CreateLocalProxy(&ep));
|
| + auto mp = MessagePipe::CreateLocalProxy(&ep);
|
| Init(std::move(ep));
|
|
|
| std::vector<scoped_refptr<PlatformHandleDispatcher>> dispatchers;
|
| @@ -494,7 +494,7 @@ TEST_P(MultiprocessMessagePipeTestWithPipeCount, PlatformHandlePassing) {
|
| // Wait for it to become readable, which should fail.
|
| HandleSignalsState hss;
|
| EXPECT_EQ(MOJO_RESULT_FAILED_PRECONDITION,
|
| - test::WaitIfNecessary(mp, MOJO_HANDLE_SIGNAL_READABLE, &hss));
|
| + test::WaitIfNecessary(mp.get(), MOJO_HANDLE_SIGNAL_READABLE, &hss));
|
| EXPECT_EQ(MOJO_HANDLE_SIGNAL_PEER_CLOSED, hss.satisfied_signals);
|
| EXPECT_EQ(MOJO_HANDLE_SIGNAL_PEER_CLOSED, hss.satisfiable_signals);
|
|
|
|
|