Issue 1396493003: Include included files in depfiles.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1396493003: Include included files in depfiles. (Closed)

Created:
5 years, 2 months ago by Dirk Pranke

Modified:
5 years, 2 months ago

Reviewers:
brettw

CC:
grit-developer_googlegroups.com

Base URL:
https://chromium.googlesource.com/external/grit-i18n.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Include included files in depfiles. Previously, we would record the dependencies on files that were being pulled in via <structure> nodes but not <include> nodes. R=brettw@chromium.org BUG=http://crbug.com/541158

Patch Set 1 #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -2 lines)			Patch
	M	grit/node/misc.py	View		1 chunk	+4 lines, -2 lines	0 comments	Download
	M	grit/node/misc_unittest.py	View		1 chunk	+25 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Dirk Pranke

5 years, 2 months ago (2015-10-08 23:44:19 UTC) #3

Committed manually by brettw@ in the grit svn repo @ r200.

Expand Messages | Collapse Messages