Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Unified Diff: grit/node/misc_unittest.py

Issue 1396493003: Include included files in depfiles. (Closed) Base URL: https://chromium.googlesource.com/external/grit-i18n.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « grit/node/misc.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: grit/node/misc_unittest.py
diff --git a/grit/node/misc_unittest.py b/grit/node/misc_unittest.py
index dea81b65fd3b5128e3efaa79f84649195d44c723..005cbf6cf4fe63cbaf6236ac01437978c3a8663d 100644
--- a/grit/node/misc_unittest.py
+++ b/grit/node/misc_unittest.py
@@ -81,6 +81,31 @@ class GritNodeUnittest(unittest.TestCase):
actual = [path.replace('\\', '/') for path in actual]
self.assertEquals(expected, actual)
+ # Verifies that GetInputFiles() returns the correct list of files
+ # when files include other files.
+ def testGetInputFilesFromIncludes(self):
+ chrome_html_path = util.PathFromRoot('grit/testdata/chrome_html.html')
+ xml = '''<?xml version="1.0" encoding="utf-8"?>
+ <grit latest_public_release="0" current_release="1">
+ <outputs>
+ <output filename="default.pak" type="data_package" context="default_100_percent" />
+ <output filename="special.pak" type="data_package" context="special_100_percent" fallback_to_default_layout="false" />
+ </outputs>
+ <release seq="1">
+ <includes>
+ <include name="IDR_TESTDATA_CHROME_HTML" file="%s" flattenhtml="true"
+ allowexternalscript="true" type="BINDATA" />
+ </includes>
+ </release>
+ </grit>''' % chrome_html_path
+
+ grd = grd_reader.Parse(StringIO.StringIO(xml), util.PathFromRoot('grit/testdata'))
+ expected = ['chrome_html.html', 'included_sample.html']
+ actual = [os.path.relpath(path, util.PathFromRoot('grit/testdata')) for path in grd.GetInputFiles()]
+ # Convert path separator for Windows paths.
+ actual = [path.replace('\\', '/') for path in actual]
+ self.assertEquals(expected, actual)
+
class IfNodeUnittest(unittest.TestCase):
def testIffyness(self):
« no previous file with comments | « grit/node/misc.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698