Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(633)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1396243002: Using the correct target NSView to show the dictionary bubble. (Closed)

Created:
5 years, 2 months ago by Shu Chen
Modified:
5 years, 2 months ago
Reviewers:
no sievers, ccameron
CC:
chromium-reviews, yusukes+watch_chromium.org, shuchen+watch_chromium.org, jam, nona+watch_chromium.org, darin-cc_chromium.org, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Using the correct target NSView to show the dictionary bubble. BUG=535961 TEST=Bug not repro. Committed: https://crrev.com/5b73303d09e0374f2b40079a2925e0fe279a7d9b Cr-Commit-Position: refs/heads/master@{#353685}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -9 lines) Patch
M content/browser/renderer_host/render_widget_host_view_mac.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 4 chunks +12 lines, -7 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac_dictionary_helper.mm View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
Shu Chen
sievers@, can you please review this cl? Thanks
5 years, 2 months ago (2015-10-10 09:09:32 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1396243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1396243002/1
5 years, 2 months ago (2015-10-10 09:10:08 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-10 09:56:36 UTC) #6
no sievers
+ccameron
5 years, 2 months ago (2015-10-12 17:17:21 UTC) #8
ccameron
Works for me locally -- lgtm
5 years, 2 months ago (2015-10-12 18:55:03 UTC) #9
no sievers
On 2015/10/12 18:55:03, ccameron wrote: > Works for me locally -- lgtm lgtm
5 years, 2 months ago (2015-10-12 19:25:08 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1396243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1396243002/1
5 years, 2 months ago (2015-10-13 04:43:29 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-13 05:41:58 UTC) #13
commit-bot: I haz the power
5 years, 2 months ago (2015-10-13 05:43:09 UTC) #14
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/5b73303d09e0374f2b40079a2925e0fe279a7d9b
Cr-Commit-Position: refs/heads/master@{#353685}

Powered by Google App Engine
This is Rietveld 408576698