content/browser/renderer_host/render_widget_host_view_mac_dictionary_helper.mm - Issue 1396243002: Using the correct target NSView to show the dictionary bubble.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_mac_dictionary_helper.mm

Issue 1396243002: Using the correct target NSView to show the dictionary bubble. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/renderer_host/render_widget_host_view_mac_dictionary_helper.mm

diff --git a/content/browser/renderer_host/render_widget_host_view_mac_dictionary_helper.mm b/content/browser/renderer_host/render_widget_host_view_mac_dictionary_helper.mm

index e0041777fef1e85f532cb516f6c8ad2b6b7c966c..4e5849d36613b7c5f5891891de0862d266e505e8 100644

--- a/content/browser/renderer_host/render_widget_host_view_mac_dictionary_helper.mm

+++ b/content/browser/renderer_host/render_widget_host_view_mac_dictionary_helper.mm

@@ -22,7 +22,9 @@ void RenderWidgetHostViewMacDictionaryHelper::SetTargetView(

void RenderWidgetHostViewMacDictionaryHelper::ShowDefinitionForSelection() {

NSRange selection_range = [view_->cocoa_view() selectedRange];

- [view_->cocoa_view() showLookUpDictionaryOverlayFromRange:selection_range];

+ NSView* view = target_view_->cocoa_view();

+ [view_->cocoa_view() showLookUpDictionaryOverlayFromRange:selection_range

+ targetView:view];

}

} // namespace content

« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_mac.mm ('k') | no next file » | no next file with comments »