Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 1396113004: Don't use base::MessageLoop::{Quit,QuitClosure} in media/ (Closed)

Created:
5 years, 2 months ago by ki.stfu
Modified:
5 years, 2 months ago
Reviewers:
ddorwin
CC:
chromium-reviews, imcheng+watch_chromium.org, posciak+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, xjz+watch_chromium.org, isheriff+watch_chromium.org, mlamouri+watch-media_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't use base::MessageLoop::{Quit,QuitClosure} in media/ This patch renames base::MessageLoop::{Quit,QuitClosure} to base::MessageLoop::{QuitWhenIdle,QuitWhenIdleClosure}. BUG=131220 R=ddorwin@chromium.org Committed: https://crrev.com/c771afc1670c3a0799d89704509ac1403ec82d92 Cr-Commit-Position: refs/heads/master@{#353600}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -32 lines) Patch
M media/audio/android/audio_android_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/audio_input_controller_unittest.cc View 2 chunks +9 lines, -8 lines 0 comments Download
M media/audio/audio_input_unittest.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M media/audio/audio_low_latency_input_output_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M media/audio/audio_output_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/audio_output_device_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/audio/fake_audio_worker_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/win/audio_low_latency_input_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/win/audio_low_latency_output_win_unittest.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M media/base/android/media_source_player_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/cast/test/sender.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/test/pipeline_integration_test_base.cc View 5 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
ki.stfu
5 years, 2 months ago (2015-10-09 19:11:20 UTC) #1
ki.stfu
Friendly ping.
5 years, 2 months ago (2015-10-12 19:06:56 UTC) #3
ddorwin
You can drop empty TEST= (and B=) lines from the description. LGTM
5 years, 2 months ago (2015-10-12 20:45:33 UTC) #4
ki.stfu
On 2015/10/12 20:45:33, ddorwin wrote: > You can drop empty TEST= (and B=) lines from ...
5 years, 2 months ago (2015-10-12 21:18:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1396113004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1396113004/1
5 years, 2 months ago (2015-10-12 21:21:06 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-12 21:48:57 UTC) #8
commit-bot: I haz the power
5 years, 2 months ago (2015-10-12 21:49:48 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c771afc1670c3a0799d89704509ac1403ec82d92
Cr-Commit-Position: refs/heads/master@{#353600}

Powered by Google App Engine
This is Rietveld 408576698