Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Side by Side Diff: media/audio/fake_audio_worker_unittest.cc

Issue 1396113004: Don't use base::MessageLoop::{Quit,QuitClosure} in media/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/bind.h" 5 #include "base/bind.h"
6 #include "base/message_loop/message_loop.h" 6 #include "base/message_loop/message_loop.h"
7 #include "base/time/time.h" 7 #include "base/time/time.h"
8 #include "media/audio/audio_parameters.h" 8 #include "media/audio/audio_parameters.h"
9 #include "media/audio/fake_audio_worker.h" 9 #include "media/audio/fake_audio_worker.h"
10 #include "media/audio/simple_sources.h" 10 #include "media/audio/simple_sources.h"
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
69 } else { 69 } else {
70 end_time_ = base::TimeTicks::Now(); 70 end_time_ = base::TimeTicks::Now();
71 EndTest(callbacks); 71 EndTest(callbacks);
72 } 72 }
73 } 73 }
74 74
75 void EndTest(int callbacks) { 75 void EndTest(int callbacks) {
76 ASSERT_TRUE(message_loop_.task_runner()->BelongsToCurrentThread()); 76 ASSERT_TRUE(message_loop_.task_runner()->BelongsToCurrentThread());
77 fake_worker_.Stop(); 77 fake_worker_.Stop();
78 EXPECT_LE(callbacks, seen_callbacks_); 78 EXPECT_LE(callbacks, seen_callbacks_);
79 message_loop_.PostTask(FROM_HERE, base::MessageLoop::QuitClosure()); 79 message_loop_.PostTask(FROM_HERE, base::MessageLoop::QuitWhenIdleClosure());
80 } 80 }
81 81
82 protected: 82 protected:
83 base::MessageLoop message_loop_; 83 base::MessageLoop message_loop_;
84 AudioParameters params_; 84 AudioParameters params_;
85 FakeAudioWorker fake_worker_; 85 FakeAudioWorker fake_worker_;
86 base::TimeTicks start_time_; 86 base::TimeTicks start_time_;
87 base::TimeTicks end_time_; 87 base::TimeTicks end_time_;
88 base::TimeDelta time_between_callbacks_; 88 base::TimeDelta time_between_callbacks_;
89 int seen_callbacks_; 89 int seen_callbacks_;
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
132 // chance of catching the worker doing the wrong thing. 132 // chance of catching the worker doing the wrong thing.
133 message_loop_.PostDelayedTask(FROM_HERE, base::Bind( 133 message_loop_.PostDelayedTask(FROM_HERE, base::Bind(
134 &FakeAudioWorkerTest::StopStartOnAudioThread, 134 &FakeAudioWorkerTest::StopStartOnAudioThread,
135 base::Unretained(this)), time_between_callbacks_ / 2); 135 base::Unretained(this)), time_between_callbacks_ / 2);
136 136
137 // EndTest() will ensure the proper number of callbacks have occurred. 137 // EndTest() will ensure the proper number of callbacks have occurred.
138 message_loop_.Run(); 138 message_loop_.Run();
139 } 139 }
140 140
141 } // namespace media 141 } // namespace media
OLDNEW
« no previous file with comments | « media/audio/audio_output_device_unittest.cc ('k') | media/audio/win/audio_low_latency_input_win_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698