Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1396083003: Don't use base::MessageLoop::{Quit,QuitClosure} in ash/, chromeos/, device/ (Closed)

Created:
5 years, 2 months ago by ki.stfu
Modified:
5 years, 2 months ago
CC:
chromium-reviews, sadrul, hashimoto+watch_chromium.org, dcheng, scheib+watch_chromium.org, oshima+watch_chromium.org, kalyank
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't use base::MessageLoop::{Quit,QuitClosure} in ash/, chromeos/, device/ This patch renames base::MessageLoop::{Quit,QuitClosure} to base::MessageLoop::{QuitWhenIdle,QuitWhenIdleClosure}. BUG=131220 TEST= R=oshima@chromium.org,stevenjb@chromium.org,reillyg@chromium.org Committed: https://crrev.com/55e0b3620524432d77cd3f707acd6ed470c2f1c9 Cr-Commit-Position: refs/heads/master@{#353548}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -33 lines) Patch
M ash/drag_drop/drag_drop_interactive_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/shelf_layout_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shell/shell_delegate_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/test/shelf_view_test_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/test/test_system_tray_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/dbus/services/service_provider_test_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/login/auth/mock_auth_status_consumer.cc View 1 chunk +10 lines, -10 lines 0 comments Download
M chromeos/login/auth/mock_url_fetchers.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chromeos/process_proxy/process_proxy_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M device/bluetooth/bluetooth_chromeos_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M device/bluetooth/bluetooth_gatt_chromeos_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/bluetooth/bluetooth_socket_chromeos_unittest.cc View 6 chunks +8 lines, -8 lines 0 comments Download
M device/bluetooth/test/test_bluetooth_adapter_observer.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (2 generated)
ki.stfu
5 years, 2 months ago (2015-10-10 08:21:46 UTC) #1
ki.stfu
oshima@: please review ash/ stevenjb@: please review chromeos/ reillyg@: please review device/
5 years, 2 months ago (2015-10-10 08:27:58 UTC) #2
oshima
lgtm
5 years, 2 months ago (2015-10-10 23:24:06 UTC) #3
Reilly Grant (use Gerrit)
lgtm but it would be better to rewrite tests to use RunLoop instead of just ...
5 years, 2 months ago (2015-10-11 00:10:46 UTC) #4
ki.stfu
On 2015/10/11 00:10:46, Reilly Grant wrote: > lgtm but it would be better to rewrite ...
5 years, 2 months ago (2015-10-11 20:13:04 UTC) #5
stevenjb
lgtm
5 years, 2 months ago (2015-10-12 16:57:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1396083003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1396083003/1
5 years, 2 months ago (2015-10-12 17:04:52 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-12 17:46:06 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-10-12 17:46:46 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/55e0b3620524432d77cd3f707acd6ed470c2f1c9
Cr-Commit-Position: refs/heads/master@{#353548}

Powered by Google App Engine
This is Rietveld 408576698