Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1012)

Unified Diff: chromeos/login/auth/mock_auth_status_consumer.cc

Issue 1396083003: Don't use base::MessageLoop::{Quit,QuitClosure} in ash/, chromeos/, device/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromeos/dbus/services/service_provider_test_helper.cc ('k') | chromeos/login/auth/mock_url_fetchers.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/login/auth/mock_auth_status_consumer.cc
diff --git a/chromeos/login/auth/mock_auth_status_consumer.cc b/chromeos/login/auth/mock_auth_status_consumer.cc
index abf6e96908a1fbbc9b615b149f01f0171616fbef..1d8e14d01488ef74bf4882dbbbbaee87be4c2615 100644
--- a/chromeos/login/auth/mock_auth_status_consumer.cc
+++ b/chromeos/login/auth/mock_auth_status_consumer.cc
@@ -19,59 +19,59 @@ MockAuthStatusConsumer::~MockAuthStatusConsumer() {
// static
void MockAuthStatusConsumer::OnRetailModeSuccessQuit(
const UserContext& user_context) {
- base::MessageLoop::current()->Quit();
+ base::MessageLoop::current()->QuitWhenIdle();
}
// static
void MockAuthStatusConsumer::OnRetailModeSuccessQuitAndFail(
const UserContext& user_context) {
ADD_FAILURE() << "Retail mode login should have failed!";
- base::MessageLoop::current()->Quit();
+ base::MessageLoop::current()->QuitWhenIdle();
}
// static
void MockAuthStatusConsumer::OnGuestSuccessQuit() {
- base::MessageLoop::current()->Quit();
+ base::MessageLoop::current()->QuitWhenIdle();
}
// static
void MockAuthStatusConsumer::OnGuestSuccessQuitAndFail() {
ADD_FAILURE() << "Guest login should have failed!";
- base::MessageLoop::current()->Quit();
+ base::MessageLoop::current()->QuitWhenIdle();
}
// static
void MockAuthStatusConsumer::OnSuccessQuit(const UserContext& user_context) {
- base::MessageLoop::current()->Quit();
+ base::MessageLoop::current()->QuitWhenIdle();
}
// static
void MockAuthStatusConsumer::OnSuccessQuitAndFail(
const UserContext& user_context) {
ADD_FAILURE() << "Login should NOT have succeeded!";
- base::MessageLoop::current()->Quit();
+ base::MessageLoop::current()->QuitWhenIdle();
}
// static
void MockAuthStatusConsumer::OnFailQuit(const AuthFailure& error) {
- base::MessageLoop::current()->Quit();
+ base::MessageLoop::current()->QuitWhenIdle();
}
// static
void MockAuthStatusConsumer::OnFailQuitAndFail(const AuthFailure& error) {
ADD_FAILURE() << "Login should not have failed!";
- base::MessageLoop::current()->Quit();
+ base::MessageLoop::current()->QuitWhenIdle();
}
// static
void MockAuthStatusConsumer::OnMigrateQuit() {
- base::MessageLoop::current()->Quit();
+ base::MessageLoop::current()->QuitWhenIdle();
}
// static
void MockAuthStatusConsumer::OnMigrateQuitAndFail() {
ADD_FAILURE() << "Should not have detected a PW change!";
- base::MessageLoop::current()->Quit();
+ base::MessageLoop::current()->QuitWhenIdle();
}
} // namespace chromeos
« no previous file with comments | « chromeos/dbus/services/service_provider_test_helper.cc ('k') | chromeos/login/auth/mock_url_fetchers.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698