Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 1395723002: Fixed upgrade failures to only throw once not on each wrap_jso (Closed)

Created:
5 years, 2 months ago by terry
Modified:
5 years, 2 months ago
Reviewers:
Alan Knight, Jacob
CC:
reviews_dartlang.org, ricow1
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Merged #

Patch Set 3 : Merged #

Patch Set 4 : Update to get latest WebKit changes. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -10 lines) Patch
M sdk/lib/html/dartium/html_dartium.dart View 1 2 6 chunks +12 lines, -4 lines 1 comment Download
M tools/deps/dartium.deps/DEPS View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/dartium/html_dartium.darttemplate View 1 2 3 chunks +6 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_HTMLDocument.darttemplate View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A + tools/dom/templates/html/impl/impl_HTMLElement.darttemplate View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
terry
5 years, 2 months ago (2015-10-07 21:04:27 UTC) #2
Alan Knight
lgtm
5 years, 2 months ago (2015-10-07 21:25:39 UTC) #3
terry
Committed patchset #4 (id:60001) manually as c9b553aad1eeee56634efa9e59a7421ecd04598b (presubmit successful).
5 years, 2 months ago (2015-10-07 21:37:31 UTC) #4
Jacob
5 years, 2 months ago (2015-10-08 00:18:17 UTC) #5
Message was sent while issue was closed.
https://codereview.chromium.org/1395723002/diff/60001/sdk/lib/html/dartium/ht...
File sdk/lib/html/dartium/html_dartium.dart (right):

https://codereview.chromium.org/1395723002/diff/60001/sdk/lib/html/dartium/ht...
sdk/lib/html/dartium/html_dartium.dart:1339: +        dartInstance.badUpgrade();
change badUpdate to a private name or just use the fields directly.

there is a risk this name could collide with user visible classes and seeing it
in the debugger will be a confusing experience for users.

Powered by Google App Engine
This is Rietveld 408576698