tools/dom/templates/html/impl/impl_HTMLElement.darttemplate - Issue 1395723002: Fixed upgrade failures to only throw once not on each wrap_jso

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/dom/templates/html/impl/impl_HTMLElement.darttemplate

Issue 1395723002: Fixed upgrade failures to only throw once not on each wrap_jso (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Update to get latest WebKit changes. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file	1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file

2 // for details. All rights reserved. Use of this source code is governed by a	2 // for details. All rights reserved. Use of this source code is governed by a

3 // BSD-style license that can be found in the LICENSE file.	3 // BSD-style license that can be found in the LICENSE file.

4	4

5 part of $LIBRARYNAME;	5 part of $LIBRARYNAME;

6	6

7 @DocsEditable()	7 @DocsEditable()

8 $(ANNOTATIONS)$(NATIVESPEC)$(CLASS_MODIFIERS)class $CLASSNAME$EXTENDS$IMPLEMENTS {	8 $(ANNOTATIONS)$(NATIVESPEC)$(CLASS_MODIFIERS)class $CLASSNAME$EXTENDS$IMPLEMENTS {

9 $!MEMBERS	9 $!MEMBERS

10 $if DARTIUM	10 $if DARTIUM

11 // Override these methods for Dartium _ServiceWorker can't be abstract.	11 // Flags to only try upgrading once if there's a failure don't try upgrading

12 Stream<ErrorEvent> get onError => errorEvent.forTarget(this);	12 // anymore.

	13 bool _badUpgrade = false;

	14 bool get isBadUpgrade => _badUpgrade;

	15 void badUpgrade() { _badUpgrade = true; }

13 $endif	16 $endif

14 }	17 }

15

OLD	NEW