Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: tools/dom/templates/html/impl/impl_HTMLElement.darttemplate

Issue 1395723002: Fixed upgrade failures to only throw once not on each wrap_jso (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Update to get latest WebKit changes. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/dom/templates/html/impl/impl_HTMLElement.darttemplate
diff --git a/tools/dom/templates/html/impl/impl_ServiceWorker.darttemplate b/tools/dom/templates/html/impl/impl_HTMLElement.darttemplate
similarity index 64%
copy from tools/dom/templates/html/impl/impl_ServiceWorker.darttemplate
copy to tools/dom/templates/html/impl/impl_HTMLElement.darttemplate
index 6cb64ab3ad1ad928fd763f04f48b6a51ba93373b..02dc375652421e175638ac087f33292901c366bc 100644
--- a/tools/dom/templates/html/impl/impl_ServiceWorker.darttemplate
+++ b/tools/dom/templates/html/impl/impl_HTMLElement.darttemplate
@@ -8,8 +8,10 @@ part of $LIBRARYNAME;
$(ANNOTATIONS)$(NATIVESPEC)$(CLASS_MODIFIERS)class $CLASSNAME$EXTENDS$IMPLEMENTS {
$!MEMBERS
$if DARTIUM
- // Override these methods for Dartium _ServiceWorker can't be abstract.
- Stream<ErrorEvent> get onError => errorEvent.forTarget(this);
+ // Flags to only try upgrading once if there's a failure don't try upgrading
+ // anymore.
+ bool _badUpgrade = false;
+ bool get isBadUpgrade => _badUpgrade;
+ void badUpgrade() { _badUpgrade = true; }
$endif
}
-

Powered by Google App Engine
This is Rietveld 408576698