Chromium Code Reviews

Issue 1385073002: Create VisualStreamTimingModule (Closed)

Created:
5 years, 2 months ago by joshua.litt
Modified:
5 years, 2 months ago
Reviewers:
jvanverth1, joshualitt, robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@vb3a
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Create VisualStreamTimingModule BUG=skia: Committed: https://skia.googlesource.com/skia/+/d0f0bceb0e88d7527dc83a75a8851f115d706522

Patch Set 1 #

Total comments: 15

Patch Set 2 : feedback inc #

Total comments: 1

Patch Set 3 : feedback inc #

Unified diffs Side-by-side diffs Stats (+164 lines, -189 lines)
M tools/VisualBench/TimingStateMachine.h View 1 chunk +0 lines, -1 line 0 comments
M tools/VisualBench/VisualInteractiveModule.h View 1 chunk +6 lines, -26 lines 0 comments
M tools/VisualBench/VisualInteractiveModule.cpp View 2 chunks +13 lines, -74 lines 0 comments
M tools/VisualBench/VisualLightweightBenchModule.h View 1 chunk +6 lines, -19 lines 0 comments
M tools/VisualBench/VisualLightweightBenchModule.cpp View 6 chunks +21 lines, -69 lines 0 comments
A tools/VisualBench/VisualStreamTimingModule.h View 1 chunk +48 lines, -0 lines 0 comments
A tools/VisualBench/VisualStreamTimingModule.cpp View 1 chunk +70 lines, -0 lines 0 comments

Dependent Patchsets:

Issue 1395703002 Patch 40001
Issue 1395703002 Patch 60001

Messages

Total messages: 10 (3 generated)
joshualitt
ptal
5 years, 2 months ago (2015-10-05 21:06:00 UTC) #2
robertphillips
https://codereview.chromium.org/1385073002/diff/1/tools/VisualBench/VisualInteractiveModule.h File tools/VisualBench/VisualInteractiveModule.h (right): https://codereview.chromium.org/1385073002/diff/1/tools/VisualBench/VisualInteractiveModule.h#newcode23 tools/VisualBench/VisualInteractiveModule.h:23: This should still be an override, right ? https://codereview.chromium.org/1385073002/diff/1/tools/VisualBench/VisualLightweightBenchModule.h ...
5 years, 2 months ago (2015-10-06 12:19:46 UTC) #3
joshualitt
feedback incorporated https://codereview.chromium.org/1385073002/diff/1/tools/VisualBench/VisualInteractiveModule.h File tools/VisualBench/VisualInteractiveModule.h (right): https://codereview.chromium.org/1385073002/diff/1/tools/VisualBench/VisualInteractiveModule.h#newcode23 tools/VisualBench/VisualInteractiveModule.h:23: On 2015/10/06 12:19:46, robertphillips wrote: > This ...
5 years, 2 months ago (2015-10-07 19:33:53 UTC) #4
joshualitt
On 2015/10/07 19:33:53, joshualitt wrote: > feedback incorporated > > https://codereview.chromium.org/1385073002/diff/1/tools/VisualBench/VisualInteractiveModule.h > File tools/VisualBench/VisualInteractiveModule.h (right): ...
5 years, 2 months ago (2015-10-12 13:48:48 UTC) #5
robertphillips
lgtm https://codereview.chromium.org/1385073002/diff/20001/tools/VisualBench/VisualStreamTimingModule.h File tools/VisualBench/VisualStreamTimingModule.h (right): https://codereview.chromium.org/1385073002/diff/20001/tools/VisualBench/VisualStreamTimingModule.h#newcode19 tools/VisualBench/VisualStreamTimingModule.h:19: * rm "some" ?
5 years, 2 months ago (2015-10-12 16:51:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1385073002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1385073002/40001
5 years, 2 months ago (2015-10-14 13:54:46 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-10-14 14:49:33 UTC) #10
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/d0f0bceb0e88d7527dc83a75a8851f115d706522

Powered by Google App Engine