Fix for GM:bigblurs not actually blurring some of the rectangles on Nexus 10.

Fix for GM:bigblurs not actually blurring some of the rectangles on Nexus 10.

BUG=skia:2860
Committed: https://skia.googlesource.com/skia/+/a8e5fbdf30fb1a09c781c4aab91ec70839590626
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1395693011

[ethannicholas, 2015-10-15 17:32:33]

ethannicholas@google.com changed reviewers:
+ joshualitt@chromium.org, robertphillips@google.com

[ethannicholas, 2015-10-16 16:37:57]

Updated to switch precision as needed.

[joshualitt, 2015-10-16 20:50:43]

joshualitt@google.com changed reviewers:
+ joshualitt@google.com

[joshualitt, 2015-10-16 20:50:44]

This looks fine to me.  I asked about getting the real precision from the caps,
but:
1) The caps are pretty far from here
2) We probably need this on Android, where the low precision will cause the nan,
and on desktop it will be ignored.

Thoughts Robert?

https://codereview.chromium.org/1395693011/diff/60001/src/effects/SkBlurMaskF...
File src/effects/SkBlurMaskFilter.cpp (right):

https://codereview.chromium.org/1395693011/diff/60001/src/effects/SkBlurMaskF...
src/effects/SkBlurMaskFilter.cpp:708: 
\n

https://codereview.chromium.org/1395693011/diff/60001/src/effects/SkBlurMaskF...
src/effects/SkBlurMaskFilter.cpp:713: 
\n

https://codereview.chromium.org/1395693011/diff/60001/src/effects/SkBlurMaskF...
src/effects/SkBlurMaskFilter.cpp:715: 
\n

https://codereview.chromium.org/1395693011/diff/60001/src/effects/SkBlurMaskF...
src/effects/SkBlurMaskFilter.cpp:812: GrGLRectBlurEffect::GenKey(fPrecision, b);
We typically add a getter to this, and then just  pass it in.

[robertphillips, 2015-10-19 13:48:39]

https://codereview.chromium.org/1395693011/diff/60001/src/effects/SkBlurMaskF...
File src/effects/SkBlurMaskFilter.cpp (right):

https://codereview.chromium.org/1395693011/diff/60001/src/effects/SkBlurMaskF...
src/effects/SkBlurMaskFilter.cpp:626: }
// why is this here ? how was the constant determined ?

[ethannicholas, 2015-10-19 14:11:41]

https://codereview.chromium.org/1395693011/diff/60001/src/effects/SkBlurMaskF...
File src/effects/SkBlurMaskFilter.cpp (right):

https://codereview.chromium.org/1395693011/diff/60001/src/effects/SkBlurMaskF...
src/effects/SkBlurMaskFilter.cpp:626: }
On 2015/10/19 13:48:39, robertphillips wrote:
> // why is this here ? how was the constant determined ?

It was originally determined by "this is the size that things go wonky on the
Nexus 10", but after double-checking the OpenGL ES spec I actually should drop
it down to 16000 for safety's sake. Technically 16384 should work, but I don't
see any reason to push our luck.

[robertphillips, 2015-10-19 15:17:54]

lgtm % question

https://codereview.chromium.org/1395693011/diff/80001/src/effects/SkBlurMaskF...
File src/effects/SkBlurMaskFilter.cpp (right):

https://codereview.chromium.org/1395693011/diff/80001/src/effects/SkBlurMaskF...
src/effects/SkBlurMaskFilter.cpp:633: GrSLPrecision precision;
Is this enough? Don't we also need to check for negative values ?

[ethannicholas, 2015-10-19 15:28:40]

The CQ bit was checked by ethannicholas@google.com

[ethannicholas, 2015-10-19 15:28:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/1395693011/#ps100001
(title: " ")

[commit-bot: I haz the power, 2015-10-19 15:28:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1395693011/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1395693011/100001

[commit-bot: I haz the power, 2015-10-19 15:38:19]

Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/a8e5fbdf30fb1a09c781c4aab91ec70839590626

[ethannicholas, 2016-01-07 21:05:52]

Description was changed from

==========
Fix for GM:bigblurs not actually blurring some of the rectangles on Nexus 10.

BUG=skia:2860

Committed:
https://skia.googlesource.com/skia/+/a8e5fbdf30fb1a09c781c4aab91ec70839590626
==========

to

==========
Fix for GM:bigblurs not actually blurring some of the rectangles on Nexus 10.

BUG=skia:2860

Committed:
https://skia.googlesource.com/skia/+/a8e5fbdf30fb1a09c781c4aab91ec70839590626
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[ethannicholas, 2016-01-07 21:06:38]

Patchset #7 (id:120001) has been deleted