Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1395693009: [Editing][BugFix] Fix if condition in ReplaceSelectionCommand (Closed)

Created:
5 years, 2 months ago by yoichio
Modified:
5 years, 2 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Editing][BugFix] Fix if condition in ReplaceSelectionCommand In ReplaceSelectionCommand::doApply, we run exec BreakBlockquoteCommand to break a Mail block quote and assume BR element is inserted at endingSelection.start. Then we remove the BR element. This command is run if selection is start in a mail blockquote element. However, selection start can be modified before L1006 because of deleting selection to prepare for insertion. This CL checks the condition again. Plus, refactoring code flow. BUG=534617 Committed: https://crrev.com/41f2fa33e2126633ba36e61eed9abb365990bd49 Cr-Commit-Position: refs/heads/master@{#355497}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Update #

Total comments: 1

Patch Set 3 : aaa #

Patch Set 4 : update #

Total comments: 3

Patch Set 5 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -23 lines) Patch
A third_party/WebKit/LayoutTests/editing/execCommand/replace-crossing-mailblockquote-crash.html View 1 2 3 4 1 chunk +19 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp View 1 2 3 chunks +17 lines, -23 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
yoichio
5 years, 2 months ago (2015-10-15 02:12:20 UTC) #2
yosin_UTC9
https://codereview.chromium.org/1395693009/diff/1/third_party/WebKit/LayoutTests/editing/execCommand/534617-crash.html File third_party/WebKit/LayoutTests/editing/execCommand/534617-crash.html (right): https://codereview.chromium.org/1395693009/diff/1/third_party/WebKit/LayoutTests/editing/execCommand/534617-crash.html#newcode1 third_party/WebKit/LayoutTests/editing/execCommand/534617-crash.html:1: <html><head> nit: Please remove a space before <html>. nit: ...
5 years, 2 months ago (2015-10-15 05:57:19 UTC) #3
yosin_UTC9
https://codereview.chromium.org/1395693009/diff/20001/third_party/WebKit/LayoutTests/editing/execCommand/534617-crash.html File third_party/WebKit/LayoutTests/editing/execCommand/534617-crash.html (right): https://codereview.chromium.org/1395693009/diff/20001/third_party/WebKit/LayoutTests/editing/execCommand/534617-crash.html#newcode1 third_party/WebKit/LayoutTests/editing/execCommand/534617-crash.html:1: <!DOCTYPE html> File name should represent what test doing ...
5 years, 2 months ago (2015-10-19 08:56:57 UTC) #4
yoichio
On 2015/10/19 at 08:56:57, yosin wrote: > https://codereview.chromium.org/1395693009/diff/20001/third_party/WebKit/LayoutTests/editing/execCommand/534617-crash.html > File third_party/WebKit/LayoutTests/editing/execCommand/534617-crash.html (right): > > https://codereview.chromium.org/1395693009/diff/20001/third_party/WebKit/LayoutTests/editing/execCommand/534617-crash.html#newcode1 ...
5 years, 2 months ago (2015-10-21 05:21:28 UTC) #6
yosin_UTC9
lgtm w/ small nit in the test file. https://codereview.chromium.org/1395693009/diff/60001/third_party/WebKit/LayoutTests/editing/execCommand/replace-crossing-mailblockquote-crash.html File third_party/WebKit/LayoutTests/editing/execCommand/replace-crossing-mailblockquote-crash.html (right): https://codereview.chromium.org/1395693009/diff/60001/third_party/WebKit/LayoutTests/editing/execCommand/replace-crossing-mailblockquote-crash.html#newcode14 third_party/WebKit/LayoutTests/editing/execCommand/replace-crossing-mailblockquote-crash.html:14: document.execCommand("selectAll"); ...
5 years, 2 months ago (2015-10-21 05:45:18 UTC) #7
yoichio
https://codereview.chromium.org/1395693009/diff/60001/third_party/WebKit/LayoutTests/editing/execCommand/replace-crossing-mailblockquote-crash.html File third_party/WebKit/LayoutTests/editing/execCommand/replace-crossing-mailblockquote-crash.html (right): https://codereview.chromium.org/1395693009/diff/60001/third_party/WebKit/LayoutTests/editing/execCommand/replace-crossing-mailblockquote-crash.html#newcode14 third_party/WebKit/LayoutTests/editing/execCommand/replace-crossing-mailblockquote-crash.html:14: document.execCommand("selectAll"); On 2015/10/21 at 05:45:18, Yosi_UTC9 wrote: > nit: ...
5 years, 2 months ago (2015-10-22 05:14:22 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1395693009/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1395693009/80001
5 years, 2 months ago (2015-10-22 05:14:39 UTC) #11
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 2 months ago (2015-10-22 06:17:38 UTC) #12
commit-bot: I haz the power
5 years, 2 months ago (2015-10-22 06:18:23 UTC) #13
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/41f2fa33e2126633ba36e61eed9abb365990bd49
Cr-Commit-Position: refs/heads/master@{#355497}

Powered by Google App Engine
This is Rietveld 408576698