third_party/WebKit/LayoutTests/editing/execCommand/534617-crash.html - Issue 1395693009: [Editing][BugFix] Fix if condition in ReplaceSelectionCommand

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/editing/execCommand/534617-crash.html

Issue 1395693009: [Editing][BugFix] Fix if condition in ReplaceSelectionCommand (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp » ('j') | third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <html><head>
	yosin_UTC9 2015/10/15 05:57:18 nit: Please remove a space before <html>. nit: Ple nit: Please remove a space before <html>. nit: Please add <!DOCTYPE html> or put comment this test case requires quriks mode.
	2 <script src="../../resources/testharness.js"></script>

	3 <script src="../../resources/testharnessreport.js"></script>

	4 <script>

	5 function fuzz() {

	6 document.designMode = 'on';

	7 document.execCommand("selectAll");

	8 document.execCommand("InsertHTML", false, "<blockquote type='cite'>Line 2</b lockquote><img>");

	9 }

	10

	11 test(function () {

	12 document.addEventListener('DOMContentLoaded', fuzz);
	yosin_UTC9 2015/10/15 05:57:18 Do we really need to use "DOMContentLoaded" event? Do we really need to use "DOMContentLoaded" event? Can we use "load" event? Or, move script block after </body>?
	13 });

	14 </script>

	15 </head>

	16 <body>

	17 <blockquote type="cite"><div>Three</div></blockquote>

	18 <br>

	19 "bar"

	20 <div id="log"></div>

	21 </body>

	22 </html>

OLD	NEW