third_party/WebKit/LayoutTests/editing/execCommand/replace-crossing-mailblockquote-crash.html - Issue 1395693009: [Editing][BugFix] Fix if condition in ReplaceSelectionCommand

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/editing/execCommand/replace-crossing-mailblockquote-crash.html

Issue 1395693009: [Editing][BugFix] Fix if condition in ReplaceSelectionCommand (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp » ('j') | third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

	2 <html><head>

2 <script src="../../resources/testharness.js"></script>	3 <script src="../../resources/testharness.js"></script>

3 <script src="../../resources/testharnessreport.js"></script>	4 <script src="../../resources/testharnessreport.js"></script>

4 a	5 </head>

5 <style>	6 <body>

6 * {	7 <blockquote type="cite"><div>Three</div></blockquote>

7 font-weight:lighter;	8 <br>

8 }	9 "bar"

9 </style>

10 a

11 <style>

12 * {

13 font-weight:900;

14 }

15 </style>

16 <div id="log"></div>	10 <div id="log"></div>

17 <script>	11 <script>

18 test(function() {	12 test(function () {

19 document.designMode = 'on';	13 document.designMode = 'on';

20 document.execCommand("selectAll");	14 document.execCommand("selectAll");
	yosin_UTC9 2015/10/21 05:45:18 nit: prefer to use single-quote in JavaScript. At nit: prefer to use single-quote in JavaScript. At least, we should use one type of quote here. yoichio 2015/10/22 05:14:22 Done. Show quoted text On 2015/10/21 at 05:45:18, Yosi_UTC9 wrote: > nit: prefer to use single-quote in JavaScript. At least, we should use one type of quote here. Done.
21 document.execCommand("insertOrderedList");	15 document.execCommand("InsertHTML", false, "<blockquote type='cite'>Line 2</b lockquote><img>");

22 });	16 });

23 </script>	17 </script>

	18 </body>

	19 </html>

OLD	NEW