chrome/common/local_discovery/service_discovery_client_unittest.cc - Issue 1395103003: Don't use base::MessageLoop::{Quit,QuitClosure} in chrome/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/local_discovery/service_discovery_client_unittest.cc

Issue 1395103003: Don't use base::MessageLoop::{Quit,QuitClosure} in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/common/local_discovery/service_discovery_client_unittest.cc

diff --git a/chrome/common/local_discovery/service_discovery_client_unittest.cc b/chrome/common/local_discovery/service_discovery_client_unittest.cc

index ed6db5c6c0c679e712502cb642c0c3a41cec823a..0b77410372fa9b51046e891082da129ad99fe2c3 100644

--- a/chrome/common/local_discovery/service_discovery_client_unittest.cc

+++ b/chrome/common/local_discovery/service_discovery_client_unittest.cc

@@ -223,9 +223,7 @@ class ServiceDiscoveryTest : public ::testing::Test {

callback.Cancel();

}

- void Stop() {

- base::MessageLoop::current()->Quit();

- }

+ void Stop() { base::MessageLoop::current()->QuitWhenIdle(); }

net::MockMDnsSocketFactory socket_factory_;

net::MDnsClientImpl mdns_client_;

« no previous file with comments | « chrome/common/local_discovery/local_domain_resolver_unittest.cc ('k') | chrome/common/mac/mock_launchd.cc » ('j') | no next file with comments »