chrome/common/mac/mock_launchd.cc - Issue 1395103003: Don't use base::MessageLoop::{Quit,QuitClosure} in chrome/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/mac/mock_launchd.cc

Issue 1395103003: Don't use base::MessageLoop::{Quit,QuitClosure} in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/local_discovery/service_discovery_client_unittest.cc ('k') | chrome/common/service_process_util_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/mac/mock_launchd.cc

diff --git a/chrome/common/mac/mock_launchd.cc b/chrome/common/mac/mock_launchd.cc

index b4e80ec5851927f210e3f7a35c8462c27bbe49cb..3af8aef1b927b7428e3aa980f0beb2d7d4fcaad8 100644

--- a/chrome/common/mac/mock_launchd.cc

+++ b/chrome/common/mac/mock_launchd.cc

@@ -226,7 +226,7 @@ CFDictionaryRef MockLaunchd::CopyDictionaryByCheckingIn(CFErrorRef* error) {

bool MockLaunchd::RemoveJob(CFStringRef label, CFErrorRef* error) {

remove_called_ = true;

- message_loop_->PostTask(FROM_HERE, base::MessageLoop::QuitClosure());

+ message_loop_->PostTask(FROM_HERE, base::MessageLoop::QuitWhenIdleClosure());

return true;

}

@@ -235,7 +235,7 @@ bool MockLaunchd::RestartJob(Domain domain,

CFStringRef name,

CFStringRef session_type) {

restart_called_ = true;

- message_loop_->PostTask(FROM_HERE, base::MessageLoop::QuitClosure());

+ message_loop_->PostTask(FROM_HERE, base::MessageLoop::QuitWhenIdleClosure());

return true;

}