chrome/common/local_discovery/local_domain_resolver_unittest.cc - Issue 1395103003: Don't use base::MessageLoop::{Quit,QuitClosure} in chrome/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/local_discovery/local_domain_resolver_unittest.cc

Issue 1395103003: Don't use base::MessageLoop::{Quit,QuitClosure} in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/web_ui_test_handler.cc ('k') | chrome/common/local_discovery/service_discovery_client_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/local_discovery/local_domain_resolver_unittest.cc

diff --git a/chrome/common/local_discovery/local_domain_resolver_unittest.cc b/chrome/common/local_discovery/local_domain_resolver_unittest.cc

index f55783e8e4aae257e81d00e240b9d07c5e5fcf79..f34ff2db7d4d52f78ffe005eb3ec5c6786a20dd2 100644

--- a/chrome/common/local_discovery/local_domain_resolver_unittest.cc

+++ b/chrome/common/local_discovery/local_domain_resolver_unittest.cc

@@ -81,9 +81,9 @@ class LocalDomainResolverTest : public testing::Test {

}

void RunFor(base::TimeDelta time_period) {

- base::CancelableCallback<void()> callback(base::Bind(

- &base::MessageLoop::Quit,

- base::Unretained(base::MessageLoop::current())));

+ base::CancelableCallback<void()> callback(

+ base::Bind(&base::MessageLoop::QuitWhenIdle,

+ base::Unretained(base::MessageLoop::current())));

base::ThreadTaskRunnerHandle::Get()->PostDelayedTask(

FROM_HERE, callback.callback(), time_period);