Introduce InputMethodAuraAndroid for Aura on Android

Introduce InputMethodAuraAndroid for Aura on Android

This add an InputMethodAuraAndroid class for Aura on Android.
Note: the class is not being used anywhere yet and will only be used when
android and use_aura are true.

BUG=507792
Committed: https://crrev.com/001e85a661d29ff805cd059f007f133e8fa54116
Cr-Commit-Position: refs/heads/master@{#355345}

[bshe, 2015-10-15 17:56:21]

bshe@chromium.org changed reviewers:
+ shuchen@chromium.org

[bshe, 2015-10-15 17:56:21]

Hi Shu.

Do you mind take a look at this? It is a first step to add IME support for aura
on Android. We expect that InputMethodAuraAndroid will be different from
InputMethodMinimal or InputMethodMUS in the future. So I added this new class.
Currently, it is nothing more than a subset of InputMethodMUS.

Thanks!

Biao

[mfomitchev, 2015-10-15 18:19:58]

mfomitchev@chromium.org changed reviewers:
+ mfomitchev@chromium.org

[mfomitchev, 2015-10-15 18:19:59]

https://codereview.chromium.org/1394883004/diff/20001/ui/base/ime/input_metho...
File ui/base/ime/input_method_auraandroid.cc (right):

https://codereview.chromium.org/1394883004/diff/20001/ui/base/ime/input_metho...
ui/base/ime/input_method_auraandroid.cc:20: SetDelegate(delegate);
We don't need to call OnFocus() here like we do in the auraclank2 branch?

[bshe, 2015-10-15 18:27:14]

https://codereview.chromium.org/1394883004/diff/20001/ui/base/ime/input_metho...
File ui/base/ime/input_method_auraandroid.cc (right):

https://codereview.chromium.org/1394883004/diff/20001/ui/base/ime/input_metho...
ui/base/ime/input_method_auraandroid.cc:20: SetDelegate(delegate);
On 2015/10/15 18:19:59, mfomitchev wrote:
> We don't need to call OnFocus() here like we do in the auraclank2 branch?

I want to add it in follow up cls (probably part of the focus rules CL). Also,
the OnFocus call may not be at the correct place, so I have more time to think
about if it should be in ctor.

[mfomitchev, 2015-10-15 18:29:05]

https://codereview.chromium.org/1394883004/diff/20001/ui/base/ime/input_metho...
File ui/base/ime/input_method_auraandroid.cc (right):

https://codereview.chromium.org/1394883004/diff/20001/ui/base/ime/input_metho...
ui/base/ime/input_method_auraandroid.cc:20: SetDelegate(delegate);
On 2015/10/15 18:27:14, bshe wrote:
> On 2015/10/15 18:19:59, mfomitchev wrote:
> > We don't need to call OnFocus() here like we do in the auraclank2 branch?
> 
> I want to add it in follow up cls (probably part of the focus rules CL). Also,
> the OnFocus call may not be at the correct place, so I have more time to think
> about if it should be in ctor.

Acknowledged.

[Shu Chen, 2015-10-16 01:08:43]

I think there is no need to name the class as InputMethodAuraAndroid.
I think InputMethodAndroid is fine because ui::InputMethod interface is designed
for Aura/Views.

[bshe, 2015-10-16 13:33:35]

On 2015/10/16 01:08:43, Shu Chen wrote:
> I think there is no need to name the class as InputMethodAuraAndroid.
> I think InputMethodAndroid is fine because ui::InputMethod interface is
designed
> for Aura/Views.

I was about to rename it but saw the comment in this issue:
https://codereview.chromium.org/1409793002/diff/1/ui/shell_dialogs/BUILD.gn
Basically, we might want to add a rule to exclude files with suffix auraandroid
for all other settings. In that case, keep the name seems to make
sense?

[bshe, 2015-10-16 15:11:40]

On 2015/10/16 13:33:35, bshe wrote:
> On 2015/10/16 01:08:43, Shu Chen wrote:
> > I think there is no need to name the class as InputMethodAuraAndroid.
> > I think InputMethodAndroid is fine because ui::InputMethod interface is
> designed
> > for Aura/Views.
> 
> I was about to rename it but saw the comment in this issue:
> https://codereview.chromium.org/1409793002/diff/1/ui/shell_dialogs/BUILD.gn
> Basically, we might want to add a rule to exclude files with suffix
auraandroid
> for all other settings. In that case, keep the name seems to make
> sense?

Sorry I may have misunderstood your comment. I have renamed the class name to
InputMethodAndroid in patchset 3, but kept the file name for now. Once we know
the answers from
https://codereview.chromium.org/1409793002 I will do the corresponding change if
necessary.

[bshe, 2015-10-20 15:02:02]

On 2015/10/16 15:11:40, bshe wrote:
> On 2015/10/16 13:33:35, bshe wrote:
> > On 2015/10/16 01:08:43, Shu Chen wrote:
> > > I think there is no need to name the class as InputMethodAuraAndroid.
> > > I think InputMethodAndroid is fine because ui::InputMethod interface is
> > designed
> > > for Aura/Views.
> > 
> > I was about to rename it but saw the comment in this issue:
> > https://codereview.chromium.org/1409793002/diff/1/ui/shell_dialogs/BUILD.gn
> > Basically, we might want to add a rule to exclude files with suffix
> auraandroid
> > for all other settings. In that case, keep the name seems to make
> > sense?
> 
> Sorry I may have misunderstood your comment. I have renamed the class name to
> InputMethodAndroid in patchset 3, but kept the file name for now. Once we know
> the answers from
> https://codereview.chromium.org/1409793002 I will do the corresponding change
if
> necessary.

Uploaded a new patch according to reply in 1409793002. shu@ do you mind to take
another
look?

[Shu Chen, 2015-10-21 01:54:23]

https://codereview.chromium.org/1394883004/diff/60001/ui/base/ime/input_metho...
File ui/base/ime/input_method_android.cc (right):

https://codereview.chromium.org/1394883004/diff/60001/ui/base/ime/input_metho...
ui/base/ime/input_method_android.cc:45: if (event->is_char()) {
Are you sure this is the case for Android? I suppose is_char() only returns true
on Windows.

[bshe, 2015-10-21 14:20:25]

https://codereview.chromium.org/1394883004/diff/60001/ui/base/ime/input_metho...
File ui/base/ime/input_method_android.cc (right):

https://codereview.chromium.org/1394883004/diff/60001/ui/base/ime/input_metho...
ui/base/ime/input_method_android.cc:45: if (event->is_char()) {
On 2015/10/21 01:54:23, Shu Chen wrote:
> Are you sure this is the case for Android? I suppose is_char() only returns
true
> on Windows.

This is basically a copy of InputMethodMUS. In aura android, we set is_char
manually to true to insert character as a temporary hack. I removed the code
here in this CL. In the future we may bring it back though if we decide to use
the hack for early prototype.

[Shu Chen, 2015-10-21 15:15:14]

lgtm

[bshe, 2015-10-21 15:20:10]

The CQ bit was checked by bshe@chromium.org

[commit-bot: I haz the power, 2015-10-21 15:20:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1394883004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1394883004/80001

[commit-bot: I haz the power, 2015-10-21 15:28:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-21 15:28:07]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[bshe, 2015-10-21 17:35:03]

The CQ bit was checked by bshe@chromium.org

[bshe, 2015-10-21 17:35:03]

The patchset sent to the CQ was uploaded after l-g-t-m from shuchen@chromium.org
Link to the patchset: https://codereview.chromium.org/1394883004/#ps100001
(title: " ")

[commit-bot: I haz the power, 2015-10-21 17:36:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1394883004/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1394883004/100001

[commit-bot: I haz the power, 2015-10-21 18:22:00]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-10-21 18:23:20]

Patchset 6 (id:??) landed as
https://crrev.com/001e85a661d29ff805cd059f007f133e8fa54116
Cr-Commit-Position: refs/heads/master@{#355345}