DescriptionFind In Page doesn't correctly highlight wrapped text.
With "white-space: pre-wrap" texts which consist line break,
we get 3 ranges for documentMarker (+ve, +ve) (-ve, +ve) and (-ve, +ve).
So, when we pass -ve offset to SimpleShaper::advance which takes unsigned
value, it converts the -ve offset to very large unsigned value.
Because of this, Font::selectionRectForText "width" comes as "0",
hence no highlight after line break.
Changed SimpleShaper::advance to take int instead of unsigned.
BUG=521047
Please Note: It was regression caused by https://codereview.chromium.org/608413002
Committed: https://crrev.com/bb8a0772750a23c96d210d8e54cee4b4327611ad
Cr-Commit-Position: refs/heads/master@{#353100}
Patch Set 1 #
Messages
Total messages: 8 (2 generated)
|