Issue 608413002: Change SimpleShaper::advance to take unsigned

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 608413002: Change SimpleShaper::advance to take unsigned (Closed)

Created:
6 years, 2 months ago by eae

Modified:
6 years, 2 months ago

Reviewers:
pdr.

CC:
blink-reviews, jamesr, pdr+graphicswatchlist_chromium.org, jbroman, mkwst+moarreviews_chromium.org, danakj, Rik, Stephen Chennney, krit, rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

Change SimpleShaper::advance to take unsigned Change the SimpleShaper::advance signature and implementation to take an unsigned thereby clarifying the API and avoiding an unnecessary (and potentially unsafe) cast. R=pdr@chromium.org BUG=418570 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182871

Patch Set 1 #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	Source/platform/fonts/SimpleShaper.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	Source/platform/fonts/SimpleShaper.cpp	View		1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/608413002/1

6 years, 2 months ago (2014-09-29 22:18:37 UTC) #5

commit-bot: I haz the power

6 years, 2 months ago (2014-09-29 23:15:15 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 182871

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages