Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(698)

Unified Diff: third_party/WebKit/Source/platform/fonts/shaping/SimpleShaper.cpp

Issue 1394833002: Find In Page doesn't correctly highlight wrapped text. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/platform/fonts/shaping/SimpleShaper.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/fonts/shaping/SimpleShaper.cpp
diff --git a/third_party/WebKit/Source/platform/fonts/shaping/SimpleShaper.cpp b/third_party/WebKit/Source/platform/fonts/shaping/SimpleShaper.cpp
index 431e5a43a6aaf9dc3488fa367f25448550a5bc66..babd006dfd3be334b66895644beeb6fac72ae0b4 100644
--- a/third_party/WebKit/Source/platform/fonts/shaping/SimpleShaper.cpp
+++ b/third_party/WebKit/Source/platform/fonts/shaping/SimpleShaper.cpp
@@ -195,14 +195,14 @@ unsigned SimpleShaper::advanceInternal(TextIterator& textIterator, GlyphBuffer*
return consumedCharacters;
}
-unsigned SimpleShaper::advance(unsigned offset, GlyphBuffer* glyphBuffer)
+unsigned SimpleShaper::advance(int offset, GlyphBuffer* glyphBuffer)
{
- unsigned length = m_textRun.length();
+ int length = m_textRun.length();
if (offset > length)
offset = length;
- if (m_currentCharacter >= offset)
+ if (m_currentCharacter >= static_cast<unsigned>(offset))
return 0;
if (m_textRun.is8Bit()) {
« no previous file with comments | « third_party/WebKit/Source/platform/fonts/shaping/SimpleShaper.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698