Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(629)

Issue 139403006: Revert of Enable icu_use_data_file on Windows (Closed)

Created:
6 years, 11 months ago by jungshik at Google
Modified:
6 years, 11 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert of Enable icu_use_data_file on Windows (https://codereview.chromium.org/99473012/) Reason for revert: mini_installer somehow does not install icudtl.dat in the top product directory (alongside chrome.exe) leading to a failure in InitializeICU(). icudtl.dat is listed in both mini_installer.gypi and FILES.cfg for windows. Original issue's description: > Enable icu_use_data_file on Windows > > > Set icu_use_data_file_flag to 1 on Windows in common.gypi and make the dependency on icudata conditional on 'icu_use_data_file_flag != 0' in common.gypi, base.gyp and net.gyp > > This also requires a change in third_party/icu/icu.gyp > ( https://codereview.chromium.org/111723007/ ), which was rolled in by https://codereview.chromium.org/118313004/ > > BUG=72633 > TEST=All windows builds work fine and there's no perf regression (start-up etc). > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246387 TBR=mark@chromium.org,scottmg@chromium.org,laforge@chromium.org,maruel@chromium.org,grt@chromium.org,wtc@chromium.org NOTREECHECKS=true NOTRY=true BUG=72633 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246632

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -58 lines) Patch
M base/base.gyp View 2 chunks +10 lines, -12 lines 0 comments Download
M base/i18n/icu_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M build/common.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/installer/mini_installer.gyp View 2 chunks +1 line, -9 lines 0 comments Download
M chrome/installer/mini_installer.gypi View 2 chunks +1 line, -9 lines 0 comments Download
M chrome/installer/mini_installer/chrome.release View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/tools/build/win/FILES.cfg View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/tools/build/win/TESTS View 1 chunk +0 lines, -1 line 0 comments Download
M net/net.gyp View 2 chunks +9 lines, -18 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jungshik at Google
Created Revert of Enable icu_use_data_file on Windows
6 years, 11 months ago (2014-01-23 17:42:50 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jshin@chromium.org/139403006/1
6 years, 11 months ago (2014-01-23 17:43:32 UTC) #2
commit-bot: I haz the power
6 years, 11 months ago (2014-01-23 17:43:50 UTC) #3
Message was sent while issue was closed.
Change committed as 246632

Powered by Google App Engine
This is Rietveld 408576698