chrome/installer/mini_installer.gyp - Issue 139403006: Revert of Enable icu_use_data_file on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/mini_installer.gyp

Issue 139403006: Revert of Enable icu_use_data_file on Windows (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/installer/mini_installer.gyp

diff --git a/chrome/installer/mini_installer.gyp b/chrome/installer/mini_installer.gyp

index a7be6a6285a6d6a3645be92b15f739f97f5149b4..385c93028cad58a4bbc43251272855170de616ef 100644

--- a/chrome/installer/mini_installer.gyp

+++ b/chrome/installer/mini_installer.gyp

@@ -223,15 +223,6 @@

'target_arch_flag': '--target_arch=x86',

}],

- ['icu_use_data_file_flag == 0', {

- 'inputs': [

- '<(PRODUCT_DIR)/icudt.dll',

- ],

- }, { # else icu_use_data_file_flag != 0

- 'inputs': [

- '<(PRODUCT_DIR)/icudtl.dat',

- ],

- }],

'inputs': [

'<(create_installer_archive_py_path)',

@@ -242,6 +233,7 @@

'<(PRODUCT_DIR)/nacl_irt_x86_32.nexe',

'<(PRODUCT_DIR)/nacl_irt_x86_64.nexe',

'<(PRODUCT_DIR)/locales/en-US.pak',

+ '<(PRODUCT_DIR)/icudt.dll',

'outputs': [

# Also note that chrome.packed.7z is defined as an output in a

« no previous file with comments | « build/common.gypi ('k') | chrome/installer/mini_installer.gypi » ('j') | no next file with comments »