Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1393283008: Image filters: refactor input GPU processing into filterInputGPU(). (Closed)

Created:
5 years, 2 months ago by Stephen White
Modified:
5 years, 2 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@filter-input
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Image filters: refactor input GPU processing into filterInputGPU(). (analog of CPU version here: https://codereview.chromium.org/1404743005/) No change in behaviour; this is a straight refactoring. BUG=skia:3194 Committed: https://skia.googlesource.com/skia/+/9a70b6ef59c38f3cbe6646aed624f22155326d05

Patch Set 1 #

Patch Set 2 : Update to ToT #

Patch Set 3 : Tweak comment #

Patch Set 4 : Update to ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -29 lines) Patch
M include/core/SkImageFilter.h View 1 2 1 chunk +8 lines, -6 lines 0 comments Download
M src/core/SkImageFilter.cpp View 1 2 chunks +11 lines, -8 lines 0 comments Download
M src/effects/SkBlurImageFilter.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/effects/SkDisplacementMapEffect.cpp View 1 1 chunk +2 lines, -5 lines 0 comments Download
M src/effects/SkLightingImageFilter.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/effects/SkMorphologyImageFilter.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/effects/SkXfermodeImageFilter.cpp View 1 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 20 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1393283008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1393283008/1
5 years, 2 months ago (2015-10-15 18:01:46 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-15 18:13:07 UTC) #4
Stephen White
reed@: PTAL. Thanks
5 years, 2 months ago (2015-10-15 19:21:11 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1393283008/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1393283008/40001
5 years, 2 months ago (2015-10-15 19:21:32 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-15 19:33:50 UTC) #10
Stephen White
Brian: PTAL. Thanks!
5 years, 2 months ago (2015-10-16 18:18:49 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1393283008/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1393283008/60001
5 years, 2 months ago (2015-10-16 18:21:39 UTC) #14
bsalomon
lgtm
5 years, 2 months ago (2015-10-16 18:23:41 UTC) #15
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-16 18:30:26 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1393283008/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1393283008/60001
5 years, 2 months ago (2015-10-16 18:34:36 UTC) #19
commit-bot: I haz the power
5 years, 2 months ago (2015-10-16 18:35:18 UTC) #20
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/9a70b6ef59c38f3cbe6646aed624f22155326d05

Powered by Google App Engine
This is Rietveld 408576698