Issue 13932025: Cancel pending requests for TemplateURLs in Shutdown, instead of dtor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13932025: Cancel pending requests for TemplateURLs in Shutdown, instead of dtor. (Closed)

Created:
7 years, 8 months ago by Cait (Slow)

Modified:
7 years, 8 months ago

Reviewers:
Peter Kasting

CC:
chromium-reviews, kaiwang

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Cancel pending requests for TemplateURLs in Shutdown, instead of dtor. BUG=230920 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194392

Patch Set 3 : pure merge #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -6 lines)			Patch
	M	chrome/browser/search_engines/template_url_service.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
	M	chrome/browser/search_engines/template_url_service.cc	View	1	2 chunks	+12 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Cait (Slow)

Peter: PTAL, this is prep work for a refactoring task to eliminate RefcountedProfileKeyedService. Kai: FYI

7 years, 8 months ago (2013-04-12 19:22:52 UTC) #1

Peter Kasting

LGTM https://codereview.chromium.org/13932025/diff/1/chrome/browser/search_engines/template_url_service.cc File chrome/browser/search_engines/template_url_service.cc (right): https://codereview.chromium.org/13932025/diff/1/chrome/browser/search_engines/template_url_service.cc#newcode312 chrome/browser/search_engines/template_url_service.cc:312: if (load_handle_) { Add a comment about why ...

7 years, 8 months ago (2013-04-12 22:32:17 UTC) #2

Cait (Slow)

7 years, 8 months ago (2013-04-16 18:06:03 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r194392 (presubmit successful).

Expand Messages | Collapse Messages

Issue 13932025: Cancel pending requests for TemplateURLs in Shutdown, instead of dtor. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Comments #

Patch Set 3 : pure merge #

Messages