Cancel pending requests for TemplateURLs in Shutdown, instead of dtor.

chrome/browser/search_engines/template_url_service.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/search_engines/template_url_service.h"
 
 #include "base/auto_reset.h"
 #include "base/command_line.h"
 #include "base/compiler_specific.h"
 #include "base/environment.h"
@@ skipping 288 matching lines @@
       next_id_(kInvalidTemplateURLID + 1),
       time_provider_(&base::Time::Now),
       models_associated_(false),
       processing_syncer_changes_(false),
       pending_synced_default_search_(false),
       dsp_change_origin_(DSP_CHANGE_NOT_SYNC) {
   Init(initializers, count);
 }
 
 TemplateURLService::~TemplateURLService() {
+}
+
+void TemplateURLService::Shutdown() {
   if (load_handle_) {

[Peter Kasting, 2013/04/12 22:32:17]

Add a comment about why it's important to do this in Shutdown() instead of the
destructor.

     DCHECK(service_.get());
     service_->CancelRequest(load_handle_);
   }
-
+  service_ = NULL;
   STLDeleteElements(&template_urls_);
 }
 
 // static
 string16 TemplateURLService::GenerateKeyword(const GURL& url) {
   DCHECK(url.is_valid());
   // Strip "www." off the front of the keyword; otherwise the keyword won't work
   // properly.  See http://code.google.com/p/chromium/issues/detail?id=6984 .
   // Special case: if the host was exactly "www." (not sure this can happen but
   // perhaps with some weird intranet and custom DNS server?), ensure we at
@@ skipping 2158 matching lines @@
     // TODO(mpcomplete): If we allow editing extension keywords, then those
     // should be persisted to disk and synced.
     if (template_url->sync_guid().empty() &&
         !template_url->IsExtensionKeyword()) {
       template_url->data_.sync_guid = base::GenerateGUID();
       if (service_.get())
         service_->UpdateKeyword(template_url->data());
     }
   }
 }