Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: chrome/browser/search_engines/template_url_service.h

Issue 13932025: Cancel pending requests for TemplateURLs in Shutdown, instead of dtor. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: pure merge Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/search_engines/template_url_service.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_SEARCH_ENGINES_TEMPLATE_URL_SERVICE_H_ 5 #ifndef CHROME_BROWSER_SEARCH_ENGINES_TEMPLATE_URL_SERVICE_H_
6 #define CHROME_BROWSER_SEARCH_ENGINES_TEMPLATE_URL_SERVICE_H_ 6 #define CHROME_BROWSER_SEARCH_ENGINES_TEMPLATE_URL_SERVICE_H_
7 7
8 #include <list> 8 #include <list>
9 #include <map> 9 #include <map>
10 #include <set> 10 #include <set>
(...skipping 243 matching lines...) Expand 10 before | Expand all | Expand 10 after
254 // Also sets the out param to indicate whether the keyword belongs to an 254 // Also sets the out param to indicate whether the keyword belongs to an
255 // extension. 255 // extension.
256 string16 GetKeywordShortName(const string16& keyword, 256 string16 GetKeywordShortName(const string16& keyword,
257 bool* is_extension_keyword); 257 bool* is_extension_keyword);
258 258
259 // content::NotificationObserver implementation. 259 // content::NotificationObserver implementation.
260 virtual void Observe(int type, 260 virtual void Observe(int type,
261 const content::NotificationSource& source, 261 const content::NotificationSource& source,
262 const content::NotificationDetails& details) OVERRIDE; 262 const content::NotificationDetails& details) OVERRIDE;
263 263
264 // ProfileKeyedService implementation.
265 virtual void Shutdown() OVERRIDE;
266
264 // syncer::SyncableService implementation. 267 // syncer::SyncableService implementation.
265 268
266 // Returns all syncable TemplateURLs from this model as SyncData. This should 269 // Returns all syncable TemplateURLs from this model as SyncData. This should
267 // include every search engine and no Extension keywords. 270 // include every search engine and no Extension keywords.
268 virtual syncer::SyncDataList GetAllSyncData( 271 virtual syncer::SyncDataList GetAllSyncData(
269 syncer::ModelType type) const OVERRIDE; 272 syncer::ModelType type) const OVERRIDE;
270 // Process new search engine changes from Sync, merging them into our local 273 // Process new search engine changes from Sync, merging them into our local
271 // data. This may send notifications if local search engines are added, 274 // data. This may send notifications if local search engines are added,
272 // updated or removed. 275 // updated or removed.
273 virtual syncer::SyncError ProcessSyncChanges( 276 virtual syncer::SyncError ProcessSyncChanges(
(...skipping 393 matching lines...) Expand 10 before | Expand all | Expand 10 after
667 670
668 // This is used to log the origin of changes to the default search provider. 671 // This is used to log the origin of changes to the default search provider.
669 // We set this value to increasingly specific values when we know what is the 672 // We set this value to increasingly specific values when we know what is the
670 // cause/origin of a default search change. 673 // cause/origin of a default search change.
671 DefaultSearchChangeOrigin dsp_change_origin_; 674 DefaultSearchChangeOrigin dsp_change_origin_;
672 675
673 DISALLOW_COPY_AND_ASSIGN(TemplateURLService); 676 DISALLOW_COPY_AND_ASSIGN(TemplateURLService);
674 }; 677 };
675 678
676 #endif // CHROME_BROWSER_SEARCH_ENGINES_TEMPLATE_URL_SERVICE_H_ 679 #endif // CHROME_BROWSER_SEARCH_ENGINES_TEMPLATE_URL_SERVICE_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/search_engines/template_url_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698