Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(826)

Issue 1393043003: [arm64] Fix some signed/unsigned type inconsistencies. (Closed)

Created:
5 years, 2 months ago by jbramley
Modified:
5 years, 2 months ago
Reviewers:
Benedikt Meurer, ulan, danno
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[arm64] Fix some signed/unsigned type inconsistencies. This fixes several warnings when cross-building using GCC (since r31087, 5cf1c0b). In particular, CPURegister::code() now returns 'int', matching the other platforms (and the coding style guide). The rest of the patch consists of similar changes to make this work. BUG= Committed: https://crrev.com/29f73ad1046de941c5ae52223315bebfd6b21a2b Cr-Commit-Position: refs/heads/master@{#31176}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -113 lines) Patch
M src/arm64/assembler-arm64.h View 10 chunks +33 lines, -62 lines 0 comments Download
M src/arm64/assembler-arm64.cc View 6 chunks +12 lines, -20 lines 0 comments Download
M src/arm64/assembler-arm64-inl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/arm64/constants-arm64.h View 3 chunks +25 lines, -26 lines 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-assembler-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
jbramley
5 years, 2 months ago (2015-10-08 10:02:34 UTC) #2
jbramley
5 years, 2 months ago (2015-10-08 10:02:45 UTC) #4
Benedikt Meurer
LGTM
5 years, 2 months ago (2015-10-08 11:02:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1393043003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1393043003/1
5 years, 2 months ago (2015-10-08 11:09:03 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-08 11:32:35 UTC) #8
commit-bot: I haz the power
5 years, 2 months ago (2015-10-08 11:32:57 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/29f73ad1046de941c5ae52223315bebfd6b21a2b
Cr-Commit-Position: refs/heads/master@{#31176}

Powered by Google App Engine
This is Rietveld 408576698