src/arm64/macro-assembler-arm64.cc - Issue 1393043003: [arm64] Fix some signed/unsigned type inconsistencies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm64/macro-assembler-arm64.cc

Issue 1393043003: [arm64] Fix some signed/unsigned type inconsistencies. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/arm64/macro-assembler-arm64.cc

diff --git a/src/arm64/macro-assembler-arm64.cc b/src/arm64/macro-assembler-arm64.cc

index c893dcad330e2708ad1c5fd7816619ad702ca18a..67988299c97b6cec05e5b1aaa994791c2d05f95a 100644

--- a/src/arm64/macro-assembler-arm64.cc

+++ b/src/arm64/macro-assembler-arm64.cc

@@ -209,7 +209,7 @@ void MacroAssembler::Mov(const Register& rd, uint64_t imm) {

// halfword, and movk for subsequent halfwords.

DCHECK((reg_size % 16) == 0);

bool first_mov_done = false;

- for (unsigned i = 0; i < (rd.SizeInBits() / 16); i++) {

+ for (int i = 0; i < (rd.SizeInBits() / 16); i++) {

uint64_t imm16 = (imm >> (16 * i)) & 0xffffL;

if (imm16 != ignored_halfword) {

if (!first_mov_done) {

« no previous file with comments | « src/arm64/constants-arm64.h ('k') | test/cctest/test-assembler-arm64.cc » ('j') | no next file with comments »