Issue 1392683003: Linter hookup into AS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1392683003: Linter hookup into AS. (Closed)

Created:
5 years, 2 months ago by pquitslund

Modified:
5 years, 2 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Linter hookup into AS. Note the TODO to fix the extension manager interaction hijinx. Really we should ensure that we are only using the one in engine. At the moment, it's easy to get this wrong (as the initialization heroics herein testify). R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/695256d586cd8ccd67919223e508d1b0e64c21ec

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+86 lines, -18 lines)			Patch
M	pkg/analysis_server/lib/src/context_manager.dart	View	3 chunks	+18 lines, -11 lines	0 comments	Download
M	pkg/analysis_server/lib/src/server/driver.dart	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/pubspec.yaml	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/test/analysis/notification_errors_test.dart	View	4 chunks	+52 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/test/analysis_abstract.dart	View	2 chunks	+7 lines, -1 line	0 comments	Download
M	pkg/analyzer/lib/src/task/dart.dart	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	pkg/analyzer/test/src/task/dart_test.dart	View	2 chunks	+2 lines, -4 lines	0 comments	Download

Total messages: 5 (1 generated)

pquitslund

5 years, 2 months ago (2015-10-09 20:40:11 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
695256d586cd8ccd67919223e508d1b0e64c21ec (presubmit successful).