Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Unified Diff: pkg/analysis_server/test/analysis_abstract.dart

Issue 1392683003: Linter hookup into AS. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Merged with master. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/analysis_abstract.dart
diff --git a/pkg/analysis_server/test/analysis_abstract.dart b/pkg/analysis_server/test/analysis_abstract.dart
index 88567a1a52c17d37e37c78b0729c3737e3179a6a..77791ba276d7ab3bb7324f89e76af565acaf5812 100644
--- a/pkg/analysis_server/test/analysis_abstract.dart
+++ b/pkg/analysis_server/test/analysis_abstract.dart
@@ -15,6 +15,8 @@ import 'package:analysis_server/src/services/index/index.dart';
import 'package:analyzer/file_system/file_system.dart';
import 'package:analyzer/file_system/memory_file_system.dart';
import 'package:analyzer/instrumentation/instrumentation.dart';
+import 'package:analyzer/src/generated/engine.dart';
+import 'package:linter/src/plugin/linter_plugin.dart';
import 'package:plugin/manager.dart';
import 'package:plugin/plugin.dart';
import 'package:unittest/unittest.dart';
@@ -94,7 +96,11 @@ class AbstractAnalysisTest {
AnalysisServer createAnalysisServer(Index index) {
ServerPlugin serverPlugin = new ServerPlugin();
- List<Plugin> plugins = <Plugin>[serverPlugin];
+ // TODO(pq): this convoluted extension registry dance needs cleanup.
+ List<Plugin> plugins = <Plugin>[serverPlugin, linterPlugin];
+ // Accessing `taskManager` ensures that AE plugins are registered.
+ AnalysisEngine.instance.taskManager;
+ plugins.addAll(AnalysisEngine.instance.supportedPlugins);
addServerPlugins(plugins);
// process plugins
ExtensionManager manager = new ExtensionManager();
« no previous file with comments | « pkg/analysis_server/test/analysis/notification_errors_test.dart ('k') | pkg/analyzer/lib/src/task/dart.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698