pkg/analyzer/lib/src/task/dart.dart - Issue 1392683003: Linter hookup into AS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analyzer/lib/src/task/dart.dart

Issue 1392683003: Linter hookup into AS. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Merged with master. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/analyzer/lib/src/task/dart.dart

diff --git a/pkg/analyzer/lib/src/task/dart.dart b/pkg/analyzer/lib/src/task/dart.dart

index d4294dad7f2900c16a19d27fc9e815f750397913..9da51727a93557b03af5f5f0dcf5835d9dab60c5 100644

--- a/pkg/analyzer/lib/src/task/dart.dart

+++ b/pkg/analyzer/lib/src/task/dart.dart

@@ -2572,9 +2572,10 @@ class GenerateLintsTask extends SourceBasedAnalysisTask {

// Generate lints.

- LintGenerator.LINTERS.forEach((l) => l.reporter = errorReporter);

+ List<Linter> linters = lintRegistry[context] ?? [];

+ linters.forEach((l) => l.reporter = errorReporter);

Iterable<AstVisitor> visitors =

- LintGenerator.LINTERS.map((l) => l.getVisitor()).toList();

+ linters.map((l) => l.getVisitor()).toList();

unit.accept(new DelegatingAstVisitor(visitors.where((v) => v != null)));