Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3399)

Unified Diff: extensions/browser/guest_view/extension_view/extension_view_guest.h

Issue 1392343002: Reduce the public method footprint of GuestViewBase and derived types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments. Reverted reordering in cc files. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/guest_view/extension_view/extension_view_guest.h
diff --git a/extensions/browser/guest_view/extension_view/extension_view_guest.h b/extensions/browser/guest_view/extension_view/extension_view_guest.h
index cc968a74ea1620b69644d430b106479f40e9349f..4a9e1248a6b892db26b3c046f9da8adfaebc98b4 100644
--- a/extensions/browser/guest_view/extension_view/extension_view_guest.h
+++ b/extensions/browser/guest_view/extension_view/extension_view_guest.h
@@ -27,27 +27,26 @@ class ExtensionViewGuest
// Returns true if the navigation is successful.
bool NavigateGuest(const std::string& src, bool force_navigation);
+ private:
+ ExtensionViewGuest(content::WebContents* owner_web_contents);
+ ~ExtensionViewGuest() override;
+
// GuestViewBase implementation.
- bool CanRunInDetachedState() const override;
+ bool CanRunInDetachedState() const final;
void CreateWebContents(const base::DictionaryValue& create_params,
- const WebContentsCreatedCallback& callback) override;
- void DidInitialize(const base::DictionaryValue& create_params) override;
- void DidAttachToEmbedder() override;
- const char* GetAPINamespace() const override;
- int GetTaskPrefix() const override;
+ const WebContentsCreatedCallback& callback) final;
+ void DidInitialize(const base::DictionaryValue& create_params) final;
+ void DidAttachToEmbedder() final;
+ const char* GetAPINamespace() const final;
+ int GetTaskPrefix() const final;
// content::WebContentsObserver implementation.
void DidCommitProvisionalLoadForFrame(
content::RenderFrameHost* render_frame_host,
const GURL& url,
- ui::PageTransition transition_type) override;
- void DidNavigateMainFrame(
- const content::LoadCommittedDetails& details,
- const content::FrameNavigateParams& params) override;
-
- private:
- ExtensionViewGuest(content::WebContents* owner_web_contents);
- ~ExtensionViewGuest() override;
+ ui::PageTransition transition_type) final;
+ void DidNavigateMainFrame(const content::LoadCommittedDetails& details,
+ const content::FrameNavigateParams& params) final;
// Applies attributes to the extensionview.
void ApplyAttributes(const base::DictionaryValue& params);

Powered by Google App Engine
This is Rietveld 408576698