Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.h

Issue 1392343002: Reduce the public method footprint of GuestViewBase and derived types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments. Reverted reordering in cc files. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.h
diff --git a/extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.h b/extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.h
index 26c0e118f04b26d97dc9e71ed73c1e5fe78f63e2..d48243052e15e17d018642d390ff617c11824e79 100644
--- a/extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.h
+++ b/extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.h
@@ -57,38 +57,40 @@ class MimeHandlerViewGuest :
static const char Type[];
+ protected:
+ explicit MimeHandlerViewGuest(content::WebContents* owner_web_contents);
+ ~MimeHandlerViewGuest() override;
+
+ private:
+ friend class TestMimeHandlerViewGuest;
+
// GuestViewBase implementation.
- const char* GetAPINamespace() const override;
- int GetTaskPrefix() const override;
+ const char* GetAPINamespace() const final;
+ int GetTaskPrefix() const final;
void CreateWebContents(const base::DictionaryValue& create_params,
const WebContentsCreatedCallback& callback) override;
void DidAttachToEmbedder() override;
- void DidInitialize(const base::DictionaryValue& create_params) override;
- bool ShouldHandleFindRequestsForEmbedder() const override;
- bool ZoomPropagatesFromEmbedderToGuest() const override;
+ void DidInitialize(const base::DictionaryValue& create_params) final;
+ bool ShouldHandleFindRequestsForEmbedder() const final;
+ bool ZoomPropagatesFromEmbedderToGuest() const final;
// WebContentsDelegate implementation.
content::WebContents* OpenURLFromTab(
content::WebContents* source,
- const content::OpenURLParams& params) override;
- bool HandleContextMenu(const content::ContextMenuParams& params) override;
+ const content::OpenURLParams& params) final;
+ bool HandleContextMenu(const content::ContextMenuParams& params) final;
bool PreHandleGestureEvent(content::WebContents* source,
- const blink::WebGestureEvent& event) override;
+ const blink::WebGestureEvent& event) final;
content::JavaScriptDialogManager* GetJavaScriptDialogManager(
- content::WebContents* source) override;
- bool SaveFrame(const GURL& url, const content::Referrer& referrer) override;
+ content::WebContents* source) final;
+ bool SaveFrame(const GURL& url, const content::Referrer& referrer) final;
// content::WebContentsObserver implementation.
- void DocumentOnLoadCompletedInMainFrame() override;
+ void DocumentOnLoadCompletedInMainFrame() final;
std::string view_id() const { return view_id_; }
base::WeakPtr<StreamContainer> GetStream() const;
- protected:
- explicit MimeHandlerViewGuest(content::WebContents* owner_web_contents);
- ~MimeHandlerViewGuest() override;
-
- private:
scoped_ptr<MimeHandlerViewGuestDelegate> delegate_;
scoped_ptr<StreamContainer> stream_;
std::string view_id_;

Powered by Google App Engine
This is Rietveld 408576698