Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: extensions/browser/guest_view/extension_options/extension_options_guest.h

Issue 1392343002: Reduce the public method footprint of GuestViewBase and derived types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments. Reverted reordering in cc files. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/guest_view/extension_options/extension_options_guest.h
diff --git a/extensions/browser/guest_view/extension_options/extension_options_guest.h b/extensions/browser/guest_view/extension_options/extension_options_guest.h
index 9cf37d26f21489e705af664a25d69837d409c2ab..eaab6dafe55104f94f9bb408fc2f90d32536d92f 100644
--- a/extensions/browser/guest_view/extension_options/extension_options_guest.h
+++ b/extensions/browser/guest_view/extension_options/extension_options_guest.h
@@ -23,24 +23,28 @@ class ExtensionOptionsGuest
static guest_view::GuestViewBase* Create(
content::WebContents* owner_web_contents);
+ private:
+ explicit ExtensionOptionsGuest(content::WebContents* owner_web_contents);
+ ~ExtensionOptionsGuest() override;
+
// GuestViewBase implementation.
- bool CanRunInDetachedState() const override;
+ bool CanRunInDetachedState() const final;
void CreateWebContents(const base::DictionaryValue& create_params,
- const WebContentsCreatedCallback& callback) override;
- void DidInitialize(const base::DictionaryValue& create_params) override;
- void GuestViewDidStopLoading() override;
- const char* GetAPINamespace() const override;
- int GetTaskPrefix() const override;
- bool IsPreferredSizeModeEnabled() const override;
- void OnPreferredSizeChanged(const gfx::Size& pref_size) override;
- bool ShouldHandleFindRequestsForEmbedder() const override;
+ const WebContentsCreatedCallback& callback) final;
+ void DidInitialize(const base::DictionaryValue& create_params) final;
+ void GuestViewDidStopLoading() final;
+ const char* GetAPINamespace() const final;
+ int GetTaskPrefix() const final;
+ bool IsPreferredSizeModeEnabled() const final;
+ void OnPreferredSizeChanged(const gfx::Size& pref_size) final;
+ bool ShouldHandleFindRequestsForEmbedder() const final;
// content::WebContentsDelegate implementation.
content::WebContents* OpenURLFromTab(
content::WebContents* source,
- const content::OpenURLParams& params) override;
- void CloseContents(content::WebContents* source) override;
- bool HandleContextMenu(const content::ContextMenuParams& params) override;
+ const content::OpenURLParams& params) final;
+ void CloseContents(content::WebContents* source) final;
+ bool HandleContextMenu(const content::ContextMenuParams& params) final;
bool ShouldCreateWebContents(
content::WebContents* web_contents,
int route_id,
@@ -49,16 +53,11 @@ class ExtensionOptionsGuest
const std::string& frame_name,
const GURL& target_url,
const std::string& partition_id,
- content::SessionStorageNamespace* session_storage_namespace) override;
+ content::SessionStorageNamespace* session_storage_namespace) final;
// content::WebContentsObserver implementation.
- void DidNavigateMainFrame(
- const content::LoadCommittedDetails& details,
- const content::FrameNavigateParams& params) override;
-
- private:
- explicit ExtensionOptionsGuest(content::WebContents* owner_web_contents);
- ~ExtensionOptionsGuest() override;
+ void DidNavigateMainFrame(const content::LoadCommittedDetails& details,
+ const content::FrameNavigateParams& params) final;
scoped_ptr<extensions::ExtensionOptionsGuestDelegate>
extension_options_guest_delegate_;

Powered by Google App Engine
This is Rietveld 408576698