Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: extensions/browser/guest_view/app_view/app_view_guest.h

Issue 1392343002: Reduce the public method footprint of GuestViewBase and derived types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments. Reverted reordering in cc files. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/guest_view/app_view/app_view_guest.h
diff --git a/extensions/browser/guest_view/app_view/app_view_guest.h b/extensions/browser/guest_view/app_view/app_view_guest.h
index d9f09013dd22015a8db250dfa357afc183dae763..c8959ca4eca169cf1a8d714529d9b468d9ab7159 100644
--- a/extensions/browser/guest_view/app_view/app_view_guest.h
+++ b/extensions/browser/guest_view/app_view/app_view_guest.h
@@ -41,24 +41,6 @@ class AppViewGuest : public guest_view::GuestView<AppViewGuest> {
static std::vector<int> GetAllRegisteredInstanceIdsForTesting();
- // content::WebContentsDelegate implementation.
- bool HandleContextMenu(const content::ContextMenuParams& params) override;
- void RequestMediaAccessPermission(
- content::WebContents* web_contents,
- const content::MediaStreamRequest& request,
- const content::MediaResponseCallback& callback) override;
- bool CheckMediaAccessPermission(content::WebContents* web_contents,
- const GURL& security_origin,
- content::MediaStreamType type) override;
-
- // GuestViewBase implementation.
- bool CanRunInDetachedState() const override;
- void CreateWebContents(const base::DictionaryValue& create_params,
- const WebContentsCreatedCallback& callback) override;
- void DidInitialize(const base::DictionaryValue& create_params) override;
- const char* GetAPINamespace() const override;
- int GetTaskPrefix() const override;
-
// Sets the AppDelegate for this guest.
void SetAppDelegateForTest(AppDelegate* delegate);
@@ -67,6 +49,24 @@ class AppViewGuest : public guest_view::GuestView<AppViewGuest> {
~AppViewGuest() override;
+ // GuestViewBase implementation.
+ bool CanRunInDetachedState() const final;
+ void CreateWebContents(const base::DictionaryValue& create_params,
+ const WebContentsCreatedCallback& callback) final;
+ void DidInitialize(const base::DictionaryValue& create_params) final;
+ const char* GetAPINamespace() const final;
+ int GetTaskPrefix() const final;
+
+ // content::WebContentsDelegate implementation.
+ bool HandleContextMenu(const content::ContextMenuParams& params) final;
+ void RequestMediaAccessPermission(
+ content::WebContents* web_contents,
+ const content::MediaStreamRequest& request,
+ const content::MediaResponseCallback& callback) final;
+ bool CheckMediaAccessPermission(content::WebContents* web_contents,
+ const GURL& security_origin,
+ content::MediaStreamType type) final;
+
void CompleteCreateWebContents(const GURL& url,
const Extension* guest_extension,
const WebContentsCreatedCallback& callback);

Powered by Google App Engine
This is Rietveld 408576698