content/browser/browser_plugin/browser_plugin_guest.h - Issue 1392343002: Reduce the public method footprint of GuestViewBase and derived types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/browser_plugin/browser_plugin_guest.h

Issue 1392343002: Reduce the public method footprint of GuestViewBase and derived types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments. Reverted reordering in cc files. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/browser_plugin/browser_plugin_embedder.cc ('k') | content/browser/browser_plugin/browser_plugin_guest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/browser_plugin/browser_plugin_guest.h

diff --git a/content/browser/browser_plugin/browser_plugin_guest.h b/content/browser/browser_plugin/browser_plugin_guest.h

index d739434d2007207c1f7108cd6a0b0a3b13e6dd98..ca81988203cd82e5ca9116e2bc9e27825522554a 100644

--- a/content/browser/browser_plugin/browser_plugin_guest.h

+++ b/content/browser/browser_plugin/browser_plugin_guest.h

@@ -251,10 +251,10 @@ class CONTENT_EXPORT BrowserPluginGuest : public GuestHost,

// Find the given |search_text| in the page. Returns true if the find request

// is handled by this browser plugin guest.

- bool Find(int request_id,

- const base::string16& search_text,

- const blink::WebFindOptions& options);

- bool StopFinding(StopFindAction action);

+ bool HandleFindForEmbedder(int request_id,

+ const base::string16& search_text,

+ const blink::WebFindOptions& options);

+ bool HandleStopFindingForEmbedder(StopFindAction action);

void ResendEventToEmbedder(const blink::WebInputEvent& event);