Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(863)

Unified Diff: content/browser/browser_plugin/browser_plugin_embedder.cc

Issue 1392343002: Reduce the public method footprint of GuestViewBase and derived types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments. Reverted reordering in cc files. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/browser_plugin/browser_plugin_embedder.cc
diff --git a/content/browser/browser_plugin/browser_plugin_embedder.cc b/content/browser/browser_plugin/browser_plugin_embedder.cc
index 04cd3ab1ec1cbeaf6a5cb112971d07424441f8cb..68899faf82a97262d07199538b91c2b01716932b 100644
--- a/content/browser/browser_plugin/browser_plugin_embedder.cc
+++ b/content/browser/browser_plugin/browser_plugin_embedder.cc
@@ -237,8 +237,9 @@ bool BrowserPluginEmbedder::FindInGuest(int request_id,
const base::string16& search_text,
const blink::WebFindOptions& options,
WebContents* guest) {
- if (static_cast<WebContentsImpl*>(guest)->GetBrowserPluginGuest()->Find(
- request_id, search_text, options)) {
+ if (static_cast<WebContentsImpl*>(guest)
+ ->GetBrowserPluginGuest()
+ ->HandleFindForEmbedder(request_id, search_text, options)) {
// There can only ever currently be one browser plugin that handles find so
// we can break the iteration at this point.
return true;
@@ -249,8 +250,9 @@ bool BrowserPluginEmbedder::FindInGuest(int request_id,
// static
bool BrowserPluginEmbedder::StopFindingInGuest(StopFindAction action,
WebContents* guest) {
- if (static_cast<WebContentsImpl*>(guest)->GetBrowserPluginGuest()
- ->StopFinding(action)) {
+ if (static_cast<WebContentsImpl*>(guest)
+ ->GetBrowserPluginGuest()
+ ->HandleStopFindingForEmbedder(action)) {
// There can only ever currently be one browser plugin that handles find so
// we can break the iteration at this point.
return true;
« no previous file with comments | « components/guest_view/browser/guest_view_base.cc ('k') | content/browser/browser_plugin/browser_plugin_guest.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698