Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Side by Side Diff: content/browser/browser_plugin/browser_plugin_guest.h

Issue 1392343002: Reduce the public method footprint of GuestViewBase and derived types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments. Reverted reordering in cc files. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // A BrowserPluginGuest is the browser side of a browser <--> embedder 5 // A BrowserPluginGuest is the browser side of a browser <--> embedder
6 // renderer channel. A BrowserPlugin (a WebPlugin) is on the embedder 6 // renderer channel. A BrowserPlugin (a WebPlugin) is on the embedder
7 // renderer side of browser <--> embedder renderer communication. 7 // renderer side of browser <--> embedder renderer communication.
8 // 8 //
9 // BrowserPluginGuest lives on the UI thread of the browser process. Any 9 // BrowserPluginGuest lives on the UI thread of the browser process. Any
10 // messages about the guest render process that the embedder might be interested 10 // messages about the guest render process that the embedder might be interested
(...skipping 233 matching lines...) Expand 10 before | Expand all | Expand 10 after
244 scoped_ptr<cc::CompositorFrame> frame); 244 scoped_ptr<cc::CompositorFrame> frame);
245 virtual void SetChildFrameSurface(const cc::SurfaceId& surface_id, 245 virtual void SetChildFrameSurface(const cc::SurfaceId& surface_id,
246 const gfx::Size& frame_size, 246 const gfx::Size& frame_size,
247 float scale_factor, 247 float scale_factor,
248 const cc::SurfaceSequence& sequence); 248 const cc::SurfaceSequence& sequence);
249 249
250 void SetContentsOpaque(bool opaque); 250 void SetContentsOpaque(bool opaque);
251 251
252 // Find the given |search_text| in the page. Returns true if the find request 252 // Find the given |search_text| in the page. Returns true if the find request
253 // is handled by this browser plugin guest. 253 // is handled by this browser plugin guest.
254 bool Find(int request_id, 254 bool HandleFindForEmbedder(int request_id,
255 const base::string16& search_text, 255 const base::string16& search_text,
256 const blink::WebFindOptions& options); 256 const blink::WebFindOptions& options);
257 bool StopFinding(StopFindAction action); 257 bool HandleStopFindingForEmbedder(StopFindAction action);
258 258
259 void ResendEventToEmbedder(const blink::WebInputEvent& event); 259 void ResendEventToEmbedder(const blink::WebInputEvent& event);
260 260
261 protected: 261 protected:
262 262
263 // BrowserPluginGuest is a WebContentsObserver of |web_contents| and 263 // BrowserPluginGuest is a WebContentsObserver of |web_contents| and
264 // |web_contents| has to stay valid for the lifetime of BrowserPluginGuest. 264 // |web_contents| has to stay valid for the lifetime of BrowserPluginGuest.
265 // Constructor protected for testing. 265 // Constructor protected for testing.
266 BrowserPluginGuest(bool has_render_view, 266 BrowserPluginGuest(bool has_render_view,
267 WebContentsImpl* web_contents, 267 WebContentsImpl* web_contents,
(...skipping 204 matching lines...) Expand 10 before | Expand all | Expand 10 after
472 // Weak pointer used to ask GeolocationPermissionContext about geolocation 472 // Weak pointer used to ask GeolocationPermissionContext about geolocation
473 // permission. 473 // permission.
474 base::WeakPtrFactory<BrowserPluginGuest> weak_ptr_factory_; 474 base::WeakPtrFactory<BrowserPluginGuest> weak_ptr_factory_;
475 475
476 DISALLOW_COPY_AND_ASSIGN(BrowserPluginGuest); 476 DISALLOW_COPY_AND_ASSIGN(BrowserPluginGuest);
477 }; 477 };
478 478
479 } // namespace content 479 } // namespace content
480 480
481 #endif // CONTENT_BROWSER_BROWSER_PLUGIN_BROWSER_PLUGIN_GUEST_H_ 481 #endif // CONTENT_BROWSER_BROWSER_PLUGIN_BROWSER_PLUGIN_GUEST_H_
OLDNEW
« no previous file with comments | « content/browser/browser_plugin/browser_plugin_embedder.cc ('k') | content/browser/browser_plugin/browser_plugin_guest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698