Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Unified Diff: components/guest_view/browser/guest_view_base.cc

Issue 1392343002: Reduce the public method footprint of GuestViewBase and derived types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments. Reverted reordering in cc files. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/guest_view/browser/guest_view_base.cc
diff --git a/components/guest_view/browser/guest_view_base.cc b/components/guest_view/browser/guest_view_base.cc
index 063850e6ed8784cf088798f7674298a13ea1bf46..564ab65ea11d3dc89c7f788283a5b125af7746b9 100644
--- a/components/guest_view/browser/guest_view_base.cc
+++ b/components/guest_view/browser/guest_view_base.cc
@@ -159,6 +159,8 @@ GuestViewBase::GuestViewBase(WebContents* owner_web_contents)
owner_web_contents->GetLastCommittedURL().host() : std::string();
}
+GuestViewBase::~GuestViewBase() {}
+
void GuestViewBase::Init(const base::DictionaryValue& create_params,
const WebContentsCreatedCallback& callback) {
if (initialized_)
@@ -407,9 +409,10 @@ void GuestViewBase::DidDetach() {
element_instance_id_ = kInstanceIDNone;
}
-bool GuestViewBase::Find(int request_id,
- const base::string16& search_text,
- const blink::WebFindOptions& options) {
+bool GuestViewBase::HandleFindForEmbedder(
+ int request_id,
+ const base::string16& search_text,
+ const blink::WebFindOptions& options) {
if (ShouldHandleFindRequestsForEmbedder()) {
web_contents()->Find(request_id, search_text, options);
return true;
@@ -417,7 +420,8 @@ bool GuestViewBase::Find(int request_id,
return false;
}
-bool GuestViewBase::StopFinding(content::StopFindAction action) {
+bool GuestViewBase::HandleStopFindingForEmbedder(
+ content::StopFindAction action) {
if (ShouldHandleFindRequestsForEmbedder()) {
web_contents()->StopFinding(action);
return true;
@@ -701,9 +705,6 @@ void GuestViewBase::FindReply(WebContents* source,
}
}
-GuestViewBase::~GuestViewBase() {
-}
-
void GuestViewBase::OnZoomChanged(
const ui_zoom::ZoomController::ZoomChangedEventData& data) {
if (data.web_contents == embedder_web_contents()) {
@@ -717,8 +718,6 @@ void GuestViewBase::OnZoomChanged(
// When the embedder's zoom level doesn't match the guest's, then update the
// guest's zoom level to match.
guest_zoom_controller->SetZoomLevel(data.new_zoom_level);
-
- EmbedderZoomChanged(data.old_zoom_level, data.new_zoom_level);
return;
}
« no previous file with comments | « components/guest_view/browser/guest_view_base.h ('k') | content/browser/browser_plugin/browser_plugin_embedder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698