Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issue 139153005: Revert "Linux: Turn --icf=safe back on for the gold linker." (Closed)

Created:
6 years, 11 months ago by Mads Ager (chromium)
Modified:
6 years, 11 months ago
Reviewers:
Lei Zhang, Chris Evans
CC:
chromium-reviews
Visibility:
Public.

Description

Revert "Linux: Turn --icf=safe back on for the gold linker." This broke the wtf_unittests when compiling with gcc: http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20%28dbg%29/builds/16904 TBR=cevans@chromium.org, thestig@chromium.org BUG=335053 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245194

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M build/common.gypi View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Mads Ager (chromium)
6 years, 11 months ago (2014-01-16 11:57:15 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ager@chromium.org/139153005/1
6 years, 11 months ago (2014-01-16 11:57:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ager@chromium.org/139153005/1
6 years, 11 months ago (2014-01-16 12:03:34 UTC) #3
Mads Ager (chromium)
Committed patchset #1 manually as r245194 (tree was closed).
6 years, 11 months ago (2014-01-16 12:19:53 UTC) #4
no longer working on chromium
6 years, 11 months ago (2014-01-16 12:38:20 UTC) #5
Message was sent while issue was closed.
Thanks Mads, I created a bug crbug/335053 to record the log and the real issue.

Powered by Google App Engine
This is Rietveld 408576698