Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(694)

Side by Side Diff: build/common.gypi

Issue 139153005: Revert "Linux: Turn --icf=safe back on for the gold linker." (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 3616 matching lines...) Expand 10 before | Expand all | Expand 10 after
3627 # '-Wl,--threads', 3627 # '-Wl,--threads',
3628 # '-Wl,--thread-count=4', 3628 # '-Wl,--thread-count=4',
3629 ], 3629 ],
3630 }], 3630 }],
3631 ], 3631 ],
3632 'conditions': [ 3632 'conditions': [
3633 ['release_valgrind_build==0', { 3633 ['release_valgrind_build==0', {
3634 'target_conditions': [ 3634 'target_conditions': [
3635 ['_toolset=="target"', { 3635 ['_toolset=="target"', {
3636 'ldflags': [ 3636 'ldflags': [
3637 '-Wl,--icf=safe', 3637 # There seems to be a conflict of --icf and -pie
3638 # in gold which can generate crashy binaries. As
3639 # a security measure, -pie takes precendence for
3640 # now.
3641 #'-Wl,--icf=safe',
3642 '-Wl,--icf=none',
3638 ], 3643 ],
3639 }], 3644 }],
3640 ], 3645 ],
3641 }], 3646 }],
3642 ], 3647 ],
3643 }], 3648 }],
3644 ['linux_use_gold_binary==1', { 3649 ['linux_use_gold_binary==1', {
3645 'ldflags': [ 3650 'ldflags': [
3646 # Put our gold binary in the search path for the linker. 3651 # Put our gold binary in the search path for the linker.
3647 # We pass the path to gold to the compiler. gyp leaves 3652 # We pass the path to gold to the compiler. gyp leaves
(...skipping 1194 matching lines...) Expand 10 before | Expand all | Expand 10 after
4842 # settings in target dicts. SYMROOT is a special case, because many other 4847 # settings in target dicts. SYMROOT is a special case, because many other
4843 # Xcode variables depend on it, including variables such as 4848 # Xcode variables depend on it, including variables such as
4844 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 4849 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
4845 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 4850 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
4846 # files to appear (when present) in the UI as actual files and not red 4851 # files to appear (when present) in the UI as actual files and not red
4847 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 4852 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
4848 # and therefore SYMROOT, needs to be set at the project level. 4853 # and therefore SYMROOT, needs to be set at the project level.
4849 'SYMROOT': '<(DEPTH)/xcodebuild', 4854 'SYMROOT': '<(DEPTH)/xcodebuild',
4850 }, 4855 },
4851 } 4856 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698