Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(637)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/common.gypi

Issue 139153005: Revert "Linux: Turn --icf=safe back on for the gold linker." (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 58e7decaff75b1349c3e60c4aabcf59c09a189bd..98cd460d508a3d1a64a98bae463b0413d344c0a5 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -3634,7 +3634,12 @@
'target_conditions': [
['_toolset=="target"', {
'ldflags': [
- '-Wl,--icf=safe',
+ # There seems to be a conflict of --icf and -pie
+ # in gold which can generate crashy binaries. As
+ # a security measure, -pie takes precendence for
+ # now.
+ #'-Wl,--icf=safe',
+ '-Wl,--icf=none',
],
}],
],
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698