Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1391373004: Bailout for large object allocations in full code EmitFastOneByteArrayJoin. (Closed)

Created:
5 years, 2 months ago by Hannes Payer (out of office)
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Bailout for large object allocations in full code EmitFastOneByteArrayJoin. BUG=chromium:542823 LOG=n Committed: https://crrev.com/24622f5f12cd3e95a38367f2be25922820a6af49 Cr-Commit-Position: refs/heads/master@{#31257}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -0 lines) Patch
M src/full-codegen/arm/full-codegen-arm.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 chunk +5 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-542823.js View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Hannes Payer (out of office)
5 years, 2 months ago (2015-10-14 11:55:20 UTC) #2
Benedikt Meurer
lgtm
5 years, 2 months ago (2015-10-14 11:58:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1391373004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1391373004/20001
5 years, 2 months ago (2015-10-14 12:02:11 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-14 12:44:31 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/24622f5f12cd3e95a38367f2be25922820a6af49 Cr-Commit-Position: refs/heads/master@{#31257}
5 years, 2 months ago (2015-10-14 12:44:53 UTC) #7
alex clarke (OOO till 29th)
5 years, 2 months ago (2015-10-19 09:13:18 UTC) #9
Message was sent while issue was closed. 
FYI the bisect suspects this patch may have caused a couple of performance
regressions, does that seem plausible? I guess there's not much we can do about
it if so :(

https://code.google.com/p/chromium/issues/detail?id=543506#c4
https://code.google.com/p/chromium/issues/detail?id=543506#c4

Powered by Google App Engine
This is Rietveld 408576698