src/full-codegen/x64/full-codegen-x64.cc - Issue 1391373004: Bailout for large object allocations in full code EmitFastOneByteArrayJoin.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/full-codegen/x64/full-codegen-x64.cc

Issue 1391373004: Bailout for large object allocations in full code EmitFastOneByteArrayJoin. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/full-codegen/x64/full-codegen-x64.cc

diff --git a/src/full-codegen/x64/full-codegen-x64.cc b/src/full-codegen/x64/full-codegen-x64.cc

index ac0d87991128a33ac820ddad1cb34eb7eab23820..c620e4863d0b81551d889560c7f270f653dfe0fb 100644

--- a/src/full-codegen/x64/full-codegen-x64.cc

+++ b/src/full-codegen/x64/full-codegen-x64.cc

@@ -4166,6 +4166,11 @@ void FullCodeGenerator::EmitFastOneByteArrayJoin(CallRuntime* expr) {

__ j(overflow, &bailout);

__ addl(string_length, scratch);

__ j(overflow, &bailout);

+ __ jmp(&bailout);

+ // Bailout for large object allocations.

+ __ cmpl(string_length, Immediate(Page::kMaxRegularHeapObjectSize));

+ __ j(greater, &bailout);

// Live registers and stack values:

// string_length: Total length of result string.

« no previous file with comments | « src/full-codegen/ppc/full-codegen-ppc.cc ('k') | test/mjsunit/regress/regress-542823.js » ('j') | no next file with comments »