Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(893)

Side by Side Diff: src/full-codegen/arm/full-codegen-arm.cc

Issue 1391373004: Bailout for large object allocations in full code EmitFastOneByteArrayJoin. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/full-codegen/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_ARM 5 #if V8_TARGET_ARCH_ARM
6 6
7 #include "src/code-factory.h" 7 #include "src/code-factory.h"
8 #include "src/code-stubs.h" 8 #include "src/code-stubs.h"
9 #include "src/codegen.h" 9 #include "src/codegen.h"
10 #include "src/debug/debug.h" 10 #include "src/debug/debug.h"
(...skipping 4227 matching lines...) Expand 10 before | Expand all | Expand 10 after
4238 // Check for smi overflow. No overflow if higher 33 bits of 64-bit result are 4238 // Check for smi overflow. No overflow if higher 33 bits of 64-bit result are
4239 // zero. 4239 // zero.
4240 __ cmp(ip, Operand::Zero()); 4240 __ cmp(ip, Operand::Zero());
4241 __ b(ne, &bailout); 4241 __ b(ne, &bailout);
4242 __ tst(scratch, Operand(0x80000000)); 4242 __ tst(scratch, Operand(0x80000000));
4243 __ b(ne, &bailout); 4243 __ b(ne, &bailout);
4244 __ add(string_length, string_length, Operand(scratch), SetCC); 4244 __ add(string_length, string_length, Operand(scratch), SetCC);
4245 __ b(vs, &bailout); 4245 __ b(vs, &bailout);
4246 __ SmiUntag(string_length); 4246 __ SmiUntag(string_length);
4247 4247
4248 // Bailout for large object allocations.
4249 __ cmp(string_length, Operand(Page::kMaxRegularHeapObjectSize));
4250 __ b(gt, &bailout);
4251
4248 // Get first element in the array to free up the elements register to be used 4252 // Get first element in the array to free up the elements register to be used
4249 // for the result. 4253 // for the result.
4250 __ add(element, 4254 __ add(element,
4251 elements, Operand(FixedArray::kHeaderSize - kHeapObjectTag)); 4255 elements, Operand(FixedArray::kHeaderSize - kHeapObjectTag));
4252 result = elements; // End of live range for elements. 4256 result = elements; // End of live range for elements.
4253 elements = no_reg; 4257 elements = no_reg;
4254 // Live values in registers: 4258 // Live values in registers:
4255 // element: First array element 4259 // element: First array element
4256 // separator: Separator string 4260 // separator: Separator string
4257 // string_length: Length of result string (not smi) 4261 // string_length: Length of result string (not smi)
(...skipping 1027 matching lines...) Expand 10 before | Expand all | Expand 10 after
5285 DCHECK(interrupt_address == 5289 DCHECK(interrupt_address ==
5286 isolate->builtins()->OsrAfterStackCheck()->entry()); 5290 isolate->builtins()->OsrAfterStackCheck()->entry());
5287 return OSR_AFTER_STACK_CHECK; 5291 return OSR_AFTER_STACK_CHECK;
5288 } 5292 }
5289 5293
5290 5294
5291 } // namespace internal 5295 } // namespace internal
5292 } // namespace v8 5296 } // namespace v8
5293 5297
5294 #endif // V8_TARGET_ARCH_ARM 5298 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/full-codegen/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698