Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Unified Diff: runtime/bin/filter.h

Issue 139043003: - Address warnings about 64-bit to 32-bit conversions. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/filter.h
===================================================================
--- runtime/bin/filter.h (revision 31816)
+++ runtime/bin/filter.h (working copy)
@@ -54,7 +54,7 @@
class ZLibDeflateFilter : public Filter {
public:
- ZLibDeflateFilter(bool gzip = false, int level = 6)
+ ZLibDeflateFilter(bool gzip = false, int32_t level = 6)
Søren Gjesse 2014/01/15 10:38:43 Just use int64_t to avoid the static cast in filte
Ivan Posva 2014/01/16 05:05:41 That would be pushing the issue just downstream. T
: gzip_(gzip), level_(level), current_buffer_(NULL) {}
virtual ~ZLibDeflateFilter();
@@ -67,7 +67,7 @@
private:
const bool gzip_;
- const int level_;
+ const int32_t level_;
uint8_t* current_buffer_;
z_stream stream_;

Powered by Google App Engine
This is Rietveld 408576698